Skip to content

Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 2/3 #110708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamappelbe merged 4 commits into from
Sep 6, 2022
Merged

Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 2/3 #110708

liamappelbe merged 4 commits into from
Sep 6, 2022

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Aug 31, 2022

Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 2/3

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 31, 2022
@liamappelbe liamappelbe mentioned this pull request Aug 31, 2022
Closed
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 31, 2022

This has test failures

@liamappelbe
Copy link
Contributor Author

liamappelbe commented Sep 1, 2022

Tests are all passing now

@liamappelbe liamappelbe marked this pull request as ready for review September 1, 2022 20:40
christopherfujino
christopherfujino approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamappelbe liamappelbe merged commit 22cef48 into flutter:master Sep 6, 2022
@liamappelbe liamappelbe deleted the null_migration_3 branch September 6, 2022 17:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
c88521c 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
f5ddbcf 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
19facfa 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
This was referenced Sep 7, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
0c6154c 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
204c96d 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
128f73e 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
22cef48 Null safety migration of packages/flutter_tools/test/commands…
55d3440 
….shard/hermetic, part 2/3 (flutter/flutter#110708)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamappelbe @christopherfujino