Skip to content

110598: expect() in semantic test producing unhelpful output #110613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 7, 2022
Merged

110598: expect() in semantic test producing unhelpful output #110613

auto-submit merged 2 commits into from
Sep 7, 2022

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Aug 30, 2022 •
edited
Loading

Fixed issue with usage of describeEnum in _MatchesSemanticsData and added tests to prevent regressions.

Resolves #110598

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pdblasi-google
110598: expect() in semantic test producing unhelpful output
6cb8094 
Fixed issue with usage of `describeEnum` in `_MatchesSemanticsData` and added tests to prevent regressions.
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 30, 2022
loic-sharma
loic-sharma reviewed Aug 30, 2022
View reviewed changes
loic-sharma
loic-sharma approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but consider get a review from someone more familiar with this area

goderbauer
goderbauer approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit 574fb1f into flutter:master Sep 7, 2022
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
574fb1f 110598: expect() in semantic test producing unhelpful output (f…
d8ef76e 
…lutter/flutter#110613)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
574fb1f 110598: expect() in semantic test producing unhelpful output (f…
d30cac2 
…lutter/flutter#110613)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
574fb1f 110598: expect() in semantic test producing unhelpful output (f…
c7fd606 
…lutter/flutter#110613)
@pdblasi-google pdblasi-google deleted the issues/110598 branch September 22, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

expect() in semantic test producing unhelpful output

3 participants

@pdblasi-google @loic-sharma @goderbauer