Skip to content

Revert "Add initial compile tests" #110550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Aug 30, 2022
Merged

Revert "Add initial compile tests" #110550

jmagman merged 1 commit into from
Aug 30, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 30, 2022

Reverts #109177

This broke all the __compile tests:

Task result:
{
  "success": false,
  "reason": "Task failed: FileSystemException: Deletion failed, path = '/opt/s/w/ir/x/w/recipe_cleanup/tmp4ehyee3m/flutter sdk/examples/hello_world/android/.gradle' (OS Error: No such file or directory, errno = 2)"
}

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804454321639298737/+/u/run_hello_world_android__compile/test_stdout

@jmagman jmagman requested review from GaryQian and zanderso August 30, 2022 00:23
@jmagman jmagman self-assigned this Aug 30, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 30, 2022
@jmagman
Copy link
Member Author

jmagman commented Aug 30, 2022

Merging to green the tree.

@jmagman jmagman merged commit 99372ba into master Aug 30, 2022
@jmagman jmagman deleted the revert-109177-compiletests branch August 30, 2022 00:46
@jmagman jmagman mentioned this pull request Aug 30, 2022
Merged
This was referenced Aug 30, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
99372ba Revert "Add initial compile tests (#109177)" (flutter/flutter…
880be2b 
…#110550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
99372ba Revert "Add initial compile tests (#109177)" (flutter/flutter…
f71310b 
…#110550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
99372ba Revert "Add initial compile tests (#109177)" (flutter/flutter…
87a9dc6 
…#110550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
99372ba Revert "Add initial compile tests (#109177)" (flutter/flutter…
162e9b0 
…#110550)
GaryQian added a commit to GaryQian/flutter that referenced this pull request Sep 14, 2022
@GaryQian
Revert "Revert "Add initial compile tests (flutter#109177)" (flutter#…
4e3c24d 
…110550)"

This reverts commit 99372ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @zanderso