Skip to content

Reland "Update accessibility contrast test coverage (#109784)" #110502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunhtai merged 1 commit into from
Sep 14, 2022
Merged

Reland "Update accessibility contrast test coverage (#109784)" #110502

chunhtai merged 1 commit into from
Sep 14, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 29, 2022

This reverts commit 41b50c2.

This is straight reland. The previous pr is reverted because internal migration applied too soon. The test should pass after cl/470742915 is landed

fixes #109465

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 29, 2022
@chunhtai chunhtai requested a review from goderbauer August 29, 2022 16:52
goderbauer
goderbauer approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM for reland.

@goderbauer
Copy link
Member

goderbauer commented Sep 13, 2022

from triage: This needs a g3fix, @chunhtai is working on it.

@chunhtai chunhtai merged commit 6b1f84f into flutter:master Sep 14, 2022
This was referenced Sep 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
6b1f84f Reland "Update accessibility contrast test coverage (#109784)" (
91aecac 
flutter/flutter#110502)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 15, 2022
@engine-flutter-autoroll
6b1f84f Reland "Update accessibility contrast test coverage (#109784)" (
f10038b 
flutter/flutter#110502)
CaseyHillers added a commit that referenced this pull request Sep 23, 2022
@CaseyHillers
Revert "Reland "Update accessibility contrast test coverage (#109784)" (
7981c83 
#110502)"

This reverts commit 6b1f84f.
@CaseyHillers CaseyHillers mentioned this pull request Sep 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve flutter contrast test coverage

2 participants

@chunhtai @goderbauer