Readability revisions for #109891 #110348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
Aug 26, 2022
Comment on lines
1408
to
1409
| await exec('tar', <String>['-zcf', 'build/app.ipa', appPath]); | ||
| releaseSizeInBytes = await file('$cwd/build/app.ipa').length(); |
Member
There was a problem hiding this comment.
Remove .ipa extension
await exec('tar', <String>['-zcf', 'build/app.tar.gz', appPath]);
releaseSizeInBytes = await file('$cwd/build/app.tar.gz').length();
Co-authored-by: Jenn Magder <magder@google.com>
loic-sharma
approved these changes
Aug 26, 2022
jmagman
approved these changes
Aug 29, 2022
Member
jmagman
left a comment
There was a problem hiding this comment.
(I shouldn't have been assigned, just kept as a reviewer).
LGTM
This was referenced Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason #109891 (review)
Related
fixes #110079
Pre-launch Checklist
///).