Skip to content

Fix some typos #110077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eggfly merged 1 commit into from
Aug 24, 2022
Merged

Fix some typos #110077

eggfly merged 1 commit into from
Aug 24, 2022

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Aug 23, 2022

  • Fix some typos

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@eggfly eggfly requested a review from Piinks as a code owner August 23, 2022 12:58
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 23, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 23, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@eggfly eggfly merged commit cf309b6 into flutter:master Aug 24, 2022
@eggfly eggfly deleted the main branch August 24, 2022 13:56
@guidezpl
Copy link
Member

guidezpl commented Aug 24, 2022

Please don't merge without a test exemption from @Hixie next time :)

@eggfly
Copy link
Member Author

eggfly commented Aug 24, 2022

Please don't merge without a test exemption from @Hixie next time :)

Oh I Got it

This was referenced Aug 24, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2022
@engine-flutter-autoroll
cf309b6 Fix some typos (flutter/flutter#110077)
8e59353
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 24, 2022
@engine-flutter-autoroll
cf309b6 Fix some typos (flutter/flutter#110077)
8b1e222
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2022
@engine-flutter-autoroll
cf309b6 Fix some typos (flutter/flutter#110077)
fbdd37b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
cf309b6 Fix some typos (flutter/flutter#110077)
c3747ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
cf309b6 Fix some typos (flutter/flutter#110077)
3232436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@Piinks Piinks Awaiting requested review from Piinks

@clocksmith clocksmith Awaiting requested review from clocksmith

@harryterkelsen harryterkelsen Awaiting requested review from harryterkelsen

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eggfly @guidezpl