Skip to content

Conversation

@aam
Copy link
Member

@aam aam commented Aug 17, 2022

This is to soften landing of a breaking change dart-lang/sdk#49647

…ethod.

This is to soften landing of a breaking change dart-lang/sdk#49647
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@aam aam requested a review from dnfield August 17, 2022 15:29
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs a test exemption from @Hixie

@aam aam requested a review from Piinks as a code owner August 17, 2022 18:26
@aam
Copy link
Member Author

aam commented Aug 17, 2022

LGTM. Needs a test exemption from @Hixie

I added a simple test that verifies that exclusive parameter is available. That required bump of a file package dependency.


testWithoutContext('create accepts exclusive argument', () {
final FileSystem fileSystem = MemoryFileSystem.test();
fileSystem.file('file').create(exclusive: true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should have some kind of expectation in the test :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@aam aam merged commit bfdc9a6 into flutter:master Aug 17, 2022
@aam aam deleted the add-exclusive branch August 17, 2022 20:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants