Add usage event when iOS app is archived #108643
Conversation
| outputDir: fileSystem.directory('/output'), | ||
| buildDir: fileSystem.directory('/build'), | ||
| projectDir: fileSystem.directory('/project'), | ||
| final Environment result = Environment.test( |
There was a problem hiding this comment.
Switched to Environment.test to pick up the defaults, including usage.
|
|
||
| await const ReleaseIosApplicationBundle().build(environment); | ||
| expect(processManager.hasRemainingExpectations, isFalse); | ||
| expect(processManager, hasNoRemainingExpectations); |
There was a problem hiding this comment.
use hasNoRemainingExpectations instead of processManager.hasRemainingExpectations, isFalse to get helpful debugging logging about which expectations are remaining.
| environment.logger.printTrace('Sending archive event if usage enabled.'); | ||
| UsageEvent( | ||
| 'assemble', | ||
| 'ios-archive', |
There was a problem hiding this comment.
Should we have an analogous event on the Android (, desktop, web, ...) side?
There was a problem hiding this comment.
Does flutter build apk already fully cover Android? Or does it have the same issue where it can be bundled and released without flutter? Web seems to say "upload a release version" which means the tool may not know if the app is being "published" or just being built in release mode. Windows and Linux both have publication instructions outside of the tool, so that may benefit from a similar pattern to this, if assemble is called, and there's some way to know it's being packaged. Each platform would need individual investigation.
|
@eliasyishak FYI only to see a patch that adds some analytics collection, no action needed. |
Add usage event within
flutter assemblewhen the app is being archived. This should cover thefluttertoolflutter build ipaas well as the in-Xcode archiving.The event is category=
assemble, parameter=ios-archive, label=successorfail.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.