Skip to content

Persistent BottomSheet are not dismissible via a11y #107435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 12, 2022
Merged

Persistent BottomSheet are not dismissible via a11y #107435

auto-submit merged 1 commit into from
Jul 12, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jul 11, 2022

Fixes #107429.

A Scaffold's persistent BottomSheet is not dismissible and therefore we shouldn't expose a dismiss action in the semantics tree.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 11, 2022
@goderbauer goderbauer requested a review from dnfield July 12, 2022 00:04
jonahwilliams
jonahwilliams approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2022
@auto-submit auto-submit bot merged commit 58e5750 into flutter:master Jul 12, 2022
This was referenced Jul 12, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 12, 2022
@engine-flutter-autoroll
58e5750 Persistent BottomSheet are not dismissible via a11y (flutter/…
984d52e 
…flutter#107435)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2022
@engine-flutter-autoroll
58e5750 Persistent BottomSheet are not dismissible via a11y (flutter/…
f5d9dd4 
…flutter#107435)
@goderbauer goderbauer deleted the fixBottomSheetSemantics branch July 12, 2022 17:26
@bdero bdero mentioned this pull request Jul 21, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@goderbauer @camsim99
Persistent BottomSheet are not dismissible via a11y (flutter#107435)
bf119fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS voice access is not working

2 participants

@goderbauer @jonahwilliams