-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix bar height changes when toggle keyboard #106542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Emm although the linux customer testing failed...I think the bottom bar height should not change...... |
|
cc @Piinks is the linux customer test fail is expected? I think the bar height should not change..... |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your contribution! Could you try rebasing your PR against the tip of tree and force pushing? That will cause us to run the tests with the latest version which may shake out the problem you're seeing. |
|
Yeah . Tests passed. Would you mind give this PR a review?😄 |
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you for the fix! Sorry it took so long to review. |
The MediaQuery.padding will change during keyboard toggling, I think we should use
MediaQuery.viewPaddinginstead ofpadding.And I modifed some old tests because they use the padding property.(It should be viewPadding)
Here is preview video, and pay attention to red bottom bar.
Before:
Before.mp4
After
After.mp4
List which issues are fixed by this PR. You must list at least one issue.
Demo code
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.