Skip to content

Update showCupertinoModalPopup documentation #106274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 20, 2022
Merged

Update showCupertinoModalPopup documentation #106274

auto-submit merged 1 commit into from
Sep 20, 2022
+1 −1

Conversation

@yunusemrebakir
Copy link
Contributor

@yunusemrebakir yunusemrebakir commented Jun 19, 2022

This PR fixes #106273

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2022
@Hixie
Copy link
Contributor

Hixie commented Sep 20, 2022

Thanks for your contribution!

Hixie
Hixie approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 20, 2022
@auto-submit auto-submit bot merged commit 6e491d8 into flutter:master Sep 20, 2022
This was referenced Sep 21, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
6e491d8 Update showCupertinoModalPopup documentation (flutter/flutter…
5420614 
…#106274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 21, 2022
@engine-flutter-autoroll
6e491d8 Update showCupertinoModalPopup documentation (flutter/flutter…
5eaf91b 
…#106274)
@MitchellGoodwin MitchellGoodwin mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Api Docs] useRootNavigator flag does not match between implementation and documentation for showCupertinoModalPopup

3 participants

@yunusemrebakir @Hixie @goderbauer