Skip to content

use super parameters in framework #103620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Aug 24, 2022
Merged

use super parameters in framework #103620

auto-submit merged 4 commits into from
Aug 24, 2022

Conversation

@newtaDev
Copy link
Contributor

@newtaDev newtaDev commented May 12, 2022

New language feature in Dart 2.17: dart-lang/language#1855

used super parameters in

  • packages/flutter/lib/src/cupertino
  • packages/flutter/lib/src/gestures
  • packages/flutter/lib/src/material
  • packages/flutter/lib/src/painting

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 12, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie
Hixie reviewed May 12, 2022
View reviewed changes
packages/flutter/lib/src/gestures/multidrag.dart Outdated
Copy link
Contributor

@Hixie Hixie May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space before {

Copy link
Contributor Author

@newtaDev newtaDev May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗,
Added space in between

@Hixie
Copy link
Contributor

Hixie commented May 12, 2022

test-exempt: code refactor with no semantic change

Hixie
Hixie approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented May 12, 2022

would be great to get a lint for this, is there a bug filed on the linter repo for one?

@newtaDev
Copy link
Contributor Author

newtaDev commented May 13, 2022

would be great to get a lint for this, is there a bug filed on the linter repo for one?

Yeah definitely,
I didn't find any open issues in the linter repo

@guidezpl
Copy link
Member

guidezpl commented Jun 3, 2022

https://dart-lang.github.io/linter/lints/use_super_parameters.html, no? It's experimental, though

@Hixie
Copy link
Contributor

Hixie commented Aug 23, 2022

cc @goderbauer

goderbauer
goderbauer approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like the use_super_params lint is not flagging these... I'll file a bug with the linter.

@goderbauer
Copy link
Member

goderbauer commented Aug 24, 2022

Filed dart-lang/sdk#58829 and dart-lang/sdk#58828.

@goderbauer
Copy link
Member

goderbauer commented Aug 24, 2022

@newtaDev Could you rebase this to the latest master to make the checks happy? Thanks.

@newtaDev
Copy link
Contributor Author

newtaDev commented Aug 24, 2022

@newtaDev Could you rebase this to the latest master to make the checks happy? Thanks.

Rebased 🤗

goderbauer
goderbauer approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2022
@auto-submit auto-submit bot merged commit 5bc4a76 into flutter:master Aug 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
5bc4a76 use super parameters in framework (flutter/flutter#103620)
5034af2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
5bc4a76 use super parameters in framework (flutter/flutter#103620)
fe7e1f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
5bc4a76 use super parameters in framework (flutter/flutter#103620)
303fb5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@newtaDev @Hixie @guidezpl @goderbauer