Skip to content

Conversation

@annagrin
Copy link
Contributor

@annagrin annagrin commented May 7, 2022

Update all packages (to bring in dwds14.0.0)

  • pass base path to the FrontendServerStrategyProvider

Closes: #102159
Closes: #85035

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@annagrin annagrin requested a review from Piinks as a code owner May 7, 2022 01:53
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 7, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@annagrin annagrin requested review from elliette, jmagman and yjbanov May 7, 2022 01:54
@goderbauer
Copy link
Member

/cc @christopherfujino, who is also working on updating packages in #103220.

text: text ?? url,
recognizer: TapGestureRecognizer()..onTap = () {
launch(url!, forceSafariVC: false);
launchUrlString(url!);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan I updated a few deprecated APIs in this directory, could you please have a look - I am not sure if parameters match correctly.

@christopherfujino
Copy link
Contributor

Thanks for opening this! However, I've already fixed most of ht failing tests on #103220, so I'm going to close this PR and patch the changes into mine.

@annagrin
Copy link
Contributor Author

annagrin commented May 9, 2022

@christopherfujino sounds good, thanks!

@annagrin annagrin deleted the annagrin/update-dwds branch May 10, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter tools debugging with web server device is not working with chrome 100.x Breakpoints are ignored when using custom base url

3 participants