Skip to content

Conversation

@itsjustkevin
Copy link
Contributor

Add post release steps to conductor output

cc: @CaseyHillers

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 19, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsjustkevin
Copy link
Contributor Author

TODO: create logic to give specific instructions based on if the release is a beta or stable release.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@itsjustkevin itsjustkevin linked an issue Apr 20, 2022 that may be closed by this pull request
@itsjustkevin itsjustkevin merged commit 0f0da62 into flutter:master Apr 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
* update console output to specify post release steps

* move post release instructions

* update instructions for beta vs stable

* add logic to differentiate beta and stable steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_conductor] Add checklist items to conductor output

2 participants