Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@dd6ef5d...5ab671f

2022-04-15 zanderso@users.noreply.github.com Reland: Ignore armv7 in ios framework script (flutter/engine#32664)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@jmagman
Copy link
Member

jmagman commented Apr 15, 2022

Will probably need the changes in #102011 applied manually. Will wait to confirm Mac framework_tests_misc failure.

'artifacts/engine/darwin-x64/FlutterMacOS.framework/Versions/A/FlutterMacOS',
'artifacts/engine/darwin-x64/font-subset',
'artifacts/engine/ios-profile/Flutter.xcframework/ios-arm64_armv7/Flutter.framework/Flutter',
'artifacts/engine/ios-profile/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagman
Copy link
Member

jmagman commented Apr 15, 2022

Not sure why the bot hasn't merged the roll in so long, going to merge manually to give myself time to revert if needed post-submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants