Skip to content

Fix the code point for CupertinoIcons.location #101923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Apr 21, 2022
Merged

Fix the code point for CupertinoIcons.location #101923

fluttergithubbot merged 1 commit into from
Apr 21, 2022

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Apr 14, 2022

Fixes #101701

@jason-simmons jason-simmons requested a review from xster April 14, 2022 18:10
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 14, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2022
@jason-simmons jason-simmons requested a review from guidezpl April 20, 2022 23:03
guidezpl
guidezpl approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a golden test be added to verify this?

@fluttergithubbot fluttergithubbot merged commit c73100b into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
f40563b 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
08cba56 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
80ba228 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
0c0db50 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
d5a3457 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
9e853c9 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
2ace2a2 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
7edb314 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
e6b325f 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
bb865be 
…er#101923)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
ffbd8bb 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
5d9c68c 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
977c540 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
a09c4b7 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
1ace3b4 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
39be20d 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
f1464d6 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
202f757 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
1aea3c7 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
24a6056 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
b9beb0e 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
6415077 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
264e988 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
a3a17b4 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
ceb27dc 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
e65f8c0 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
a7653c2 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
9560e6e 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
c7f876a 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
c903bc7 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
5bdad14 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
f459097 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
374b0df 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
d49c936 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
2b41bc0 
…er#101923)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
c73100b Fix the code point for CupertinoIcons.location (flutter/flutt…
f288c61 
…er#101923)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@jason-simmons @egramond
Fix the code point for CupertinoIcons.location (flutter#101923)
2fd04c1
This was referenced May 31, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@xster xster Awaiting requested review from xster

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cupertino_icons] CupertinoIcons.location Icon is incorrect

3 participants

@jason-simmons @guidezpl @fluttergithubbot