-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Migrate AppBar to Material 3 #101884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate AppBar to Material 3 #101884
Conversation
guidezpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though, there's no mention of the four types of app bar, is that something to add in a the future PR containing the examples?
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #101884 at sha 8d8da46b55a41a97703b6245788b931c716f47ea |
…he shadow color was transparent.
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…103101) * Add the new hash * [flutter.js] Wait for reg.update, then activate sw (if not active yet). (#101464) * Avoid scheduling a forced frame when there is no child to the renderView (#102556) * Migrate AppBar to Material 3 (#101884) * Keeping the super parameters * Fixing semi-colon issue Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Dan Field <dnfield@google.com> Co-authored-by: Darren Austin <darrenaustin@google.com>
Part of: #91605
Updated the common buttons:
ElevatedButton,OutlinedButton, andTextButtonwith support for Material Design 3.In order to use the common buttons with the new Material 3 defaults, turn on the
useMaterial3flag in theThemeData:In addition to the new look, the
AppBarandAppBarThemenow supportsurfaceTintColorandscrolledUnderElevationproperties to support the new elevation visuals needed for Material 3.By default in Material 3, the app bar will no longer have a drop shadow, but instead will show changes in elevation by applying a surface tint overlay with and opacity based on the elevation on top of the background color. In addition the default elevation is 0 when there is nothing under the app bar. This changes to 3 when something is scrolled beneath the app bar. Example of this behaviour:
Fixes: #92093
Pre-launch Checklist
///).