[flutter_tools] shard out two integration tests we want to run on macOS arm64 #101769
Conversation
jmagman
left a comment
There was a problem hiding this comment.
I don't think mac_arm.shard makes sense, these tests need to run on x64 as well...
Should also include ios_content_validation_test for the simulator arch tests.
|
4130db4 to
1f6a80c
Compare
keyonghan
left a comment
There was a problem hiding this comment.
Config LGTM, but we need to add the test ownership to pass the test.
Should this be added as a comment near the end of TESTOWNERS? I'm not sure what's going on in that file. |
That's right. |
|
cc @Jasguerrero for context, regarding our 1:1 conversation, this is what it currently takes to create a new test shard. |
.ci.yaml
Outdated
| {"dependency": "android_sdk", "version": "version:31v8"}, | ||
| {"dependency": "chrome_and_driver", "version": "version:98.1"}, | ||
| {"dependency": "open_jdk", "version": "11"}, |
There was a problem hiding this comment.
I know all the tasks have android_sdk and chrome_and_driver and open_jdk but I don't think they are needed for these tests. Can you try removing them and see if it passes? I've been meaning to audit all of them.
There was a problem hiding this comment.
SGTM, i already removed goldctl
|
New builder was created but no builds scheduled yet. For monitoring: https://ci.chromium.org/p/flutter/builders/staging/Mac%20tool_host_cross_arch_tests |
|
First seven builds all green, looks like a success https://ci.chromium.org/p/flutter/builders/staging/Mac%20tool_host_cross_arch_tests |
Moved one test from integration.shard/bash_entrypoint_test.dart and the complete file of integration.shard/macos_content_validation_test.dart to a new shard, mac_arm.shard/. Also created a new builder in .ci.yaml, copying
Mac tool_integration_tests 1_4, while deleting the goldctl dependency.