Skip to content

Pass multidex flag when using --machine mode #101689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Apr 11, 2022
Merged

Pass multidex flag when using --machine mode #101689

fluttergithubbot merged 3 commits into from
Apr 11, 2022

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Apr 11, 2022

This fixes Dart-Code/Dart-Code#3837 by ensuring the --[no-]multidex value (and default) are honoured when using --machine.

(Originally opened at #99010, but I had to re-create my fork which seems to have broken that PR).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 11, 2022
@DanTup DanTup mentioned this pull request Apr 11, 2022
Closed
8 tasks
@DanTup
Copy link
Contributor Author

DanTup commented Apr 11, 2022

@christopherfujino I found a simple way to test this, although I'm not certain it's the best way - PTAL!

christopherfujino
christopherfujino approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, sorry I never got back to you on how to test this. I started looking on it and then got distracted. I like your approach though.

Jasguerrero
Jasguerrero approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup
Copy link
Contributor Author

DanTup commented Apr 11, 2022

@christopherfujino np, I had meant to do some more digging around too but hadn't gotten to it.

Could you check what's up with the Google testing check?

@christopherfujino
Copy link
Contributor

christopherfujino commented Apr 11, 2022

It's this, manually made it green.

@fluttergithubbot fluttergithubbot merged commit b086473 into flutter:master Apr 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
b086473 Pass multidex flag when using --machine mode (flutter/flutter…
bee8fdc 
…#101689)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
b086473 Pass multidex flag when using --machine mode (flutter/flutter…
3d3e141 
…#101689)
@DanTup
Copy link
Contributor Author

DanTup commented Apr 11, 2022

@christopherfujino cool, thanks!

@DanTup DanTup mentioned this pull request Apr 11, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
b086473 Pass multidex flag when using --machine mode (flutter/flutter…
2a8440a 
…#101689)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
b086473 Pass multidex flag when using --machine mode (flutter/flutter…
204494a 
…#101689)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2022
@engine-flutter-autoroll
b086473 Pass multidex flag when using --machine mode (flutter/flutter…
4c43c22 
…#101689)
@DanTup DanTup mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argument "--machine" disables "--multidex"

4 participants

@DanTup @christopherfujino @Jasguerrero @fluttergithubbot