-
Notifications
You must be signed in to change notification settings - Fork 30.6k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 195ae7b
head repository: flutter/flutter
compare: 3f400d7
- 13 commits
- 60 files changed
- 9 contributors
Commits on Mar 10, 2026
-
dev: Use a super-parameter in several missed cases (#182251)
Work towards dart-lang/sdk#58729 The lint rule will suggest using a super-parameter for a named parameter even if the positional parameters cannot be super-parameters. I'm not sure why unrelated lines were formatted.
Configuration menu - View commit details
-
Copy full SHA for cccee58 - Browse repository at this point
Copy the full SHA cccee58View commit details -
Roll Skia from 4b35832cc7ea to 257d04225d0c (5 revisions) (#183457)
https://skia.googlesource.com/skia.git/+log/4b35832cc7ea..257d04225d0c 2026-03-10 kjlubick@google.com Fix image deserialization in mskps for dm 2026-03-10 bungeman@google.com [pdf] Map marked content in non-page streams 2026-03-10 thomsmit@google.com [graphite] Fold Depth Draws into general case 2026-03-10 sergiog@microsoft.com [rust icc] Fix GRAY profile XYZ synthesis and TRC table pass-through 2026-03-10 chengyangyang-hf@loongson.cn Expand the skpViewportSize option to fully render SKP conveniently. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for ebc8509 - Browse repository at this point
Copy the full SHA ebc8509View commit details -
Roll Dart SDK from ebef6c849489 to ae2be9700800 (4 revisions) (#183460)
https://dart.googlesource.com/sdk.git/+log/ebef6c849489..ae2be9700800 2026-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-232.0.dev 2026-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-231.0.dev 2026-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-230.0.dev 2026-03-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-229.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7584632 - Browse repository at this point
Copy the full SHA 7584632View commit details -
This PR was generated by `flutter update-packages --force-upgrade`.
Configuration menu - View commit details
-
Copy full SHA for fcead73 - Browse repository at this point
Copy the full SHA fcead73View commit details -
[material/menu_anchor.dart] Ensure positioned menus always begin anim…
…ating at the target position (#182932) This PR makes animated positioned menus (usually context menus that treat the whole screen as a menu anchor) begin opening at the user's pointer rather than the top or bottom of the menu anchor. Fixes #182929 Before: https://github.com/user-attachments/assets/5e536db6-2903-463c-82d1-9f8e8a304bd2 After (the menu closes on left-click, but repositions on right-click, unless it is external to the red menu anchor surface) https://github.com/user-attachments/assets/52597be3-2bfe-441c-b962-52b47f69b413 If possible, we should make sure this lands in stable when the menu animations land in stable. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 3c16f55 - Browse repository at this point
Copy the full SHA 3c16f55View commit details -
Fix GitHub workflows to use the
flutteractionsbotmirror for PR bra……nches. (#183470) Branch creation is restricted in `flutter/flutter` and so GitHub workflows can't (by default) create any branches on the main repository. However, the `easy_cp` workflow already works around this by using the `flutteractionsbot` mirror to host the PR branches. This PR modifies our workflows to make them in line with the strategy that `easy_cp` uses.
Configuration menu - View commit details
-
Copy full SHA for f72870a - Browse repository at this point
Copy the full SHA f72870aView commit details
Commits on Mar 11, 2026
-
Roll Skia from 257d04225d0c to 0cab3e4ee34b (8 revisions) (#183476)
https://skia.googlesource.com/skia.git/+log/257d04225d0c..0cab3e4ee34b 2026-03-10 egdaniel@google.com Make sure we are getting the correct atlas for glyph mask format. 2026-03-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b55a0e69f29d to a363b51d709a (8 revisions) 2026-03-10 michaelludwig@google.com [graphite] Temporarily relax rgbx write swizzle 2026-03-10 bungeman@google.com [canvaskit] Add underline and stikeout font metrics 2026-03-10 kjlubick@google.com Use modern imageDataProc in mskp's SkSharingProc 2026-03-10 anuszel@google.com Merge 7 release notes into RELEASE_NOTES.md 2026-03-10 anuszel@google.com Update Skia milestone to 148 2026-03-10 kjlubick@google.com Revert^2 "Remove mipmaps from SkBitmap's implementation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jimgraham@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for cefc593 - Browse repository at this point
Copy the full SHA cefc593View commit details -
Add GLES support for the same pixel formats for copying texture -> bu…
…ffer as when copying buffer -> texture (#183428) `BlitCopyBufferToTextureCommandGLES` (and initializing/setting texture contents in `TextureGLES`) supports a bunch of different pixel formats, as defined in the `TexImage2DData` constructors in `blit_command_gles.cc` and `texture_gles.cc`. But `BlitCopyTextureToBufferCommandGLES` only has support specifically for `kR8G8B8A8UNormInt` and `kB8G8R8A8UNormInt`. This makes `BlitCopyTextureToBufferCommandGLES` support the same pixel formats as `BlitCopyBufferToTextureCommandGLES` and `TextureGLES`. Fixes #183462 ## Changes: ### Share `ToPixelFormatGLES` `blit_command_gles.cc` and `texture_gles.cc` have almost-duplicate logic to convert `impeller::PixelFormat` to a `GLint internal_format`, a `GLenum external_format`, and a `GLenum type`. Factor this out into a shared `ToPixelFormatGLES` function in `formats_gles.h/cc`. Where there were differences between the `blit_command_gles.cc` and `texture_gles.cc`: - `kR32G32B32A32Float`: - `blit_command_gles.cc` has `internal_format = GL_RGBA`, `external_format = GL_RGBA` - `texture_gles.cc` has `internal_format = GL_RGBA32F`, `external_format = GL_RGBA` - I used `internal_format = GL_RGBA32F`, `external_format = GL_RGBA` - `kR16G16B16A16Float`: - `blit_command_gles.cc` has `internal_format = GL_RGBA`, `external_format = GL_RGBA` - `texture_gles.cc` has `internal_format = GL_RGBA16F`, `external_format = GL_RGBA` - I used `internal_format = GL_RGBA16F`, `external_format = GL_RGBA` - `kR32Float`: - `blit_command_gles.cc` has `internal_format = GL_RED`, `external_format = GL_RED` - `texture_gles.cc` has `internal_format = GL_R32F`, `external_format = GL_RGBA` - I used `internal_format = GL_R32F`, `external_format = GL_RED` All the other PixelFormat cases were the same between the two files and copied over directly. ### Remove `TexImage2DData` `blit_command_gles.cc` and `texture_gles.cc` each define a `TexImage2DData` struct which just contains the pixel format data and sometimes an optional data buffer. I removed both of these. Instead, we just use the `ToPixelFormatGLES` return value directly, and use the source data buffer directly. ### Improve pixel format support in `BlitCopyTextureToBufferCommandGLES::Encode()` In `BlitCopyTextureToBufferCommandGLES::Encode()`, use `ToPixelFormatGLES()` to determine the format and type used for `gl.ReadPixels()`. This expands the existing functionality that only supported two specific pixel formats. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for b07acf9 - Browse repository at this point
Copy the full SHA b07acf9View commit details -
Roll Dart SDK from ae2be9700800 to fecf806be5d0 (1 revision) (#183482)
https://dart.googlesource.com/sdk.git/+log/ae2be9700800..fecf806be5d0 2026-03-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-233.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for cc85917 - Browse repository at this point
Copy the full SHA cc85917View commit details -
[impeller] Use the GLES3 shaders in the embedder if supported (#180072)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Adds the GLES3 shaders to the embedder (used by Linux and custom embedders) if they are supported. Fixes #179185 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Jason Simmons <jsimmons@google.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0b3147c - Browse repository at this point
Copy the full SHA 0b3147cView commit details -
Roll Dart SDK from fecf806be5d0 to 8531f7c2bdae (2 revisions) (#183489)
https://dart.googlesource.com/sdk.git/+log/fecf806be5d0..8531f7c2bdae 2026-03-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-235.0.dev 2026-03-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.12.0-234.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 995ce27 - Browse repository at this point
Copy the full SHA 995ce27View commit details -
Roll Fuchsia Linux SDK from 8C_qfgWgoNhkV0_Mn... to QD887D4OanteB7UKM…
…... (#183492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 640a089 - Browse repository at this point
Copy the full SHA 640a089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f400d7 - Browse repository at this point
Copy the full SHA 3f400d7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 195ae7b...3f400d7