Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0541913
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1ceffd1
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on May 14, 2026

  1. Fix nested Text.rich semantics order (#186116) 

    Fixes #176570

Nested `Text.rich` widgets can inherit placeholder semantics tags from
ancestor paragraphs. When those inherited tags reuse the same
placeholder index as the nested paragraph, `RenderParagraph` can merge
all placeholder child semantics before the inline text segment.

This emits combined text semantics in span order and matches placeholder
children against the direct placeholder tag so nested widget spans keep
their accessibility label order.

Tests:
- `../../bin/flutter test test/widgets/text_test.dart
--plain-name='semantics label is in order with nested rich text widget
spans'`
- `../../bin/flutter test test/widgets/text_test.dart`
- `../../bin/flutter analyze --no-pub lib/src/rendering/paragraph.dart
test/widgets/text_test.dart`
    @gabrimatic
    gabrimatic authored May 14, 2026
    Configuration menu
    Copy the full SHA
    987d8c5 View commit details
    Browse the repository at this point in the history

  2. Fix selection highlight artifacts for faded selectable text (#183628) 

    ## Summary

Fixes a rendering artifact when selecting text inside `SelectionArea`
for a `Text`/`RichText` that uses `TextOverflow.fade`.

Previously, `RenderParagraph` painted selection highlights into the same
saveLayer used for the fade overflow shader. That caused the fade
compositing path to affect the selection rects and produced dark
border/line artifacts during selection.

This change separates selection highlight painting from the faded text
layer so the fade shader only applies to the text content.

Fixes: #182776

## Changes

- Paint `RenderParagraph` selection highlights outside the overflow fade
saveLayer

## Screenshots

| Before | After |
|--------|-------|
|
![Before](https://github.com/user-attachments/assets/22c3c8a1-3d17-40f3-8b77-fc48e9e91a25)
|
![After](https://github.com/user-attachments/assets/dbca31d9-edb0-4dea-a617-0bf8c2b809a8)
|
    @ikramhasan
    ikramhasan authored May 14, 2026
    Configuration menu
    Copy the full SHA
    1ceffd1 View commit details
    Browse the repository at this point in the history
Loading