Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 81c87ea165df
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bf18e3958a05
Choose a head ref
  • 18 commits
  • 144 files changed
  • 14 contributors

Commits on Apr 9, 2026

  1. UberSDFContent refactoring and handle stroke miter limit for stroked …

    …rects (#184603)
    
    Creates a new UberSDFParameters struct, which is encapsulates all the
    state needed for a UberSDF FragInfo. It has shape-specific constructors
    to populate this state for different shapes.
    
    Creates a new UberSDFGeometry class to be used as the Geometry for
    UberSDFContents. It contains all the AA padding logic for UberSDF, so
    the AA padding can be removed from canvas and from FillRectGeometry.
    UberSDFGeometry's GetPositionBuffer leverages a FillRectGeometry to
    return a quad that properly accounts for AA padding.
    
    UberSDFContents is updated to be constructed with UberSDFParameters
    rather than having shape-specific constructors. It becomes agnostic to
    the specific shape being drawn, and now has no shape- or geometry-aware
    logic. It simply pipes through UberSDFParameters values to the UberSDF
    shader's FragInfo.
    
    This is mostly a no-op refactoring. The exception is for UberSDF stroke
    rects with a miter limit. UberSDFParameters properly handles miter limit
    for these, so now stroked rects with low miter limits properly become
    beveled.
    
    Part of #184402
    Fixes #184404
    Part of #184352
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Jim Graham <flar@google.com>
    b-luk and flar authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    47b5032 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 4d0f5389e131 to af67d5555e35 (3 revisions) (#184825)

    https://skia.googlesource.com/skia.git/+log/4d0f5389e131..af67d5555e35
    
    2026-04-09 sergiog@microsoft.com [rust jpeg] Default rust ICC and EXIF
    kill switches to enabled
    2026-04-09 kosuch@opera.com Fix SkJSONReader float parsing
    2026-04-09 sergiog@microsoft.com [rust bmp] Fix of rust ICC padding
    issue with skcms_Transform
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    8b9d733 View commit details
    Browse the repository at this point in the history
  3. Update link for rolling forward to aligned Dart hash (#184780)

    Related to
    https://chat.google.com/room/AAAAc_4rqiI/DaS2vV_AX2g/IjFs6apfiHY?cls=10
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    reidbaker authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    ab267fe View commit details
    Browse the repository at this point in the history
  4. Disable async mode with LLDB (#184768)

    @mraleph proposed a [better
    fix](#184254 (comment))
    for the LLDB Xcode 26.4 breakage and I confirmed that it works.
    
    This PR reverts the first fix and adopts the new one, which is to set
    LLDB to not use async mode.
    
    For #184254.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    vashworth authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    eb4e55a View commit details
    Browse the repository at this point in the history
  5. [record_use] Add experimental flag and test project (#184719)

    Bug:
    
    * dart-lang/native#2690
    
    **Does _not_ add an implementation**, only:
    - an experimental flag,
    - an integration test that should pass when the experiment is
    implemented,
    - and the record_use package as an explicit dependency.
    
    Landing this PR first because it's a ton of files. It will keep the
    actual implementation PR more reviewable.
    
    Note the test projects go through the usual hoops:
    
    * `flutter create`.
    * Add the things we want to test.
    * Add copyright headers everywhere.
    * Drop all the icons, and modify all the native build files to not refer
    to the icons. (Force pushing 10x in the process to get the bots green.)
    * The build_tests shards build the test projects for all target OSes
    (catching things such as misconfigured icons etc.)
    
    The integration test loosely follows the data assets integration test,
    but it only runs release mode (so no hot reload and hot restart).
    
    The integration test uses data assets (not code assets) so that we can
    also test the web backends with record-use. This means the integration
    test relies on also enabling the data assets experimental flag.
    dcharkes authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    eb6acab View commit details
    Browse the repository at this point in the history
  6. Roll Packages from 0e0a032a4a9b to 1aa892c09c8b (9 revisions) (#184829)

    flutter/packages@0e0a032...1aa892c
    
    2026-04-09 10687576+bparrishMines@users.noreply.github.com
    [webview_flutter_android] Adds support to opt out of Android inset
    changes (flutter/packages#11192)
    2026-04-08 engine-flutter-autoroll@skia.org Roll Flutter from
    a0924c7 to 05e0ae0 (24 revisions) (flutter/packages#11470)
    2026-04-08 stuartmorgan@google.com [pigeon] Make Kotlin FlutterError a
    runtime error (flutter/packages#11469)
    2026-04-08 stuartmorgan@google.com [path_provider] Remove dependency on
    engine PathUtils (flutter/packages#11467)
    2026-04-07 1063596+reidbaker@users.noreply.github.com [all] Prepare
    packages for skills (flutter/packages#11430)
    2026-04-07 engine-flutter-autoroll@skia.org Roll Flutter from
    9cd60b5 to a0924c7 (13 revisions) (flutter/packages#11463)
    2026-04-07 elitree@gmail.com [google_maps_flutter] Android cluster pin
    info window onTap callback not firing (flutter/packages#11390)
    2026-04-07 stuartmorgan@google.com [flutter_svg] Remove generated CMake
    files (flutter/packages#11459)
    2026-04-07 stuartmorgan@google.com [various] Convert remaining Groovy
    files to Kotlin (flutter/packages#11443)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC flutter-ecosystem@google.com on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    20a9784 View commit details
    Browse the repository at this point in the history
  7. Remove linux_android_emu_unstable android_engine_vulkan_tests (#184787

    )
    
    This was pushing to the same golden files as the stable version. I
    suspect it is the source of flakiness of the vulkan platform view gold
    tests.
    
    If we want to maintain parallel versions, we will in the future need to
    make the test harness ci-yaml-target-aware, in the way that it is for
    opengles vs vulkan.
    gmackall authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    06ce217 View commit details
    Browse the repository at this point in the history
  8. Roll Dart SDK from bd6280c3e8e9 to 98a143f8873e (5 revisions) (#184824)

    https://dart.googlesource.com/sdk.git/+log/bd6280c3e8e9..98a143f8873e
    
    2026-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-4.0.dev
    2026-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-3.0.dev
    2026-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-2.0.dev
    2026-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-1.0.dev
    2026-04-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-0.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    deede54 View commit details
    Browse the repository at this point in the history
  9. Roll Fuchsia Linux SDK from pDXMXRIjEHTw7B0sk... to lZcRfPoCLnDttrf9P…

    …... (#184842)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC jimgraham@google.com,zra@google.com on the revert to ensure
    that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    810163e View commit details
    Browse the repository at this point in the history
  10. Remove unused variable in ProcessTextPlugin.java (#184161)

    this change removes an unused variable in
    `engine/src/flutter/shell/platform/android/io/flutter/plugin/text/ProcessTextPlugin.java`.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    AbdeMohlbi authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    b31ab80 View commit details
    Browse the repository at this point in the history
  11. Skip freeze check in the merge queue (#184854)

    `merge_group` events do not have the same GitHub API access as
    `pull_request_target`, so we should skip the check in the merge queue.
    We should skip the freeze check in the merge queue. The freeze workflow
    was enabled as a required check in the branch protections in order to
    capture existing PRs and prevent them from landing. This protection made
    the check required in the merge queue, but no way for it to handle it.
    After this lands, I can re-enable the branch protection.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    Piinks authored Apr 9, 2026
    Configuration menu
    Copy the full SHA
    c6f719d View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2026

  1. Reverts "Disable async mode with LLDB (#184768)" (#184868)

    <!-- start_original_pr_link -->
    Reverts: #184768
    <!-- end_original_pr_link -->
    <!-- start_initiating_author -->
    Initiated by: flar
    <!-- end_initiating_author -->
    <!-- start_revert_reason -->
    Reason for reverting: #184867
    <!-- end_revert_reason -->
    <!-- start_original_pr_author -->
    Original PR Author: vashworth
    <!-- end_original_pr_author -->
    
    <!-- start_reviewers -->
    Reviewed By: {hellohuanlin}
    <!-- end_reviewers -->
    
    <!-- start_revert_body -->
    This change reverts the following previous change:
    @mraleph proposed a [better
    fix](#184254 (comment))
    for the LLDB Xcode 26.4 breakage and I confirmed that it works.
    
    This PR reverts the first fix and adopts the new one, which is to set
    LLDB to not use async mode.
    
    For #184254.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    If this change needs to override an active code freeze, provide a
    comment explaining why. The code freeze workflow can be overridden by
    code reviewers. See pinned issues for any active code freezes with
    guidance.
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    <!-- end_revert_body -->
    
    Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
    auto-submit[bot] and auto-submit[bot] authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    49233d0 View commit details
    Browse the repository at this point in the history
  2. Roll Dart SDK from 98a143f8873e to e715805ddbd3 (1 revision) (#184864)

    https://dart.googlesource.com/sdk.git/+log/98a143f8873e..e715805ddbd3
    
    2026-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
    Version 3.13.0-5.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    0fe62a5 View commit details
    Browse the repository at this point in the history
  3. [Dot shorthands] Finish examples/api migration (#183967)

    Migrates code in `examples/api` to use dot shorthands.
    
    Part of: #175965
    See also: [Dot shorthands style
    guide](https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-dot-shorthands-to-reduce-redundant-information)
    
    Stacked pull requests:
    * #183963
    * #183964
    * #183965
    * #183966
    * #183967
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [AI contribution guidelines]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    loic-sharma authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    3d70045 View commit details
    Browse the repository at this point in the history
  4. Roll Skia from af67d5555e35 to 25b01e5f4ea0 (14 revisions) (#184865)

    https://skia.googlesource.com/skia.git/+log/af67d5555e35..25b01e5f4ea0
    
    2026-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    vulkan-deps from 1c9ab5c20bf7 to fc3031169f9f (13 revisions)
    2026-04-09 thomsmit@google.com [graphite] Change to Pilot draw system
    2026-04-09 alexisdavidc@google.com Improve readability of
    SkScan_Hairline
    2026-04-09
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2026-04-09 egdaniel@google.com Revert "Reland "[skparagraph] Render
    visible hyphen at soft hyphen (U+00AD) line breaks""
    2026-04-09
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2026-04-09 dbebawy@gmail.com Reland "[skparagraph] Render visible hyphen
    at soft hyphen (U+00AD) line breaks"
    2026-04-09 thomsmit@google.com [graphite] sample sdf lcd text atlases at
    f32
    2026-04-09 michaelludwig@google.com [graphite] Simplify VulkanCaps
    format table initialization
    2026-04-09 nscobie@google.com Expose bitwise operators for
    skgpu::GpuStatsFlags enum in public API
    2026-04-09 kjlubick@google.com Fix compilation of d3d backend w/o
    GPU_TEST_UTILS
    2026-04-09 nicolettep@google.com [graphite] Add time-limited resource
    cache purge test
    2026-04-09 alexisdavidc@google.com Fix SkScan_Hairline cap and close
    handling
    2026-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
    vulkan-deps from eba20b140bce to 1c9ab5c20bf7 (2 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    f417bcb View commit details
    Browse the repository at this point in the history
  5. Don't use git add -N in the sync engine workflow. (#184882)

    The `-N` flag doesn't actually stage the file if it doesn't exist yet.
    This was causing this workflow to fail on initial betas, where the
    engine.version file wasn't tracked.
    eyebrowsoffire authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    c2627e8 View commit details
    Browse the repository at this point in the history
  6. Specify GitHub Repo in GH CLI calls for revert workflow. (#184878)

    Some of the GitHub CLI calls (such as the ones that looks for the
    "Reason for revert:" comments) happen before we have actually checked
    out the repo. As a result, we need to pass the repository explicitly to
    the GitHub CLI.
    eyebrowsoffire authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    b716540 View commit details
    Browse the repository at this point in the history
  7. [flutter_tools] Fix arm64e incorrectly matching arm64 in regex check (#…

    …184057)
    
    Fixes #184056
    
    The regex `EXCLUDED_ARCHS.*arm64` in `pluginsSupportArmSimulator()`
    matches
    `arm64e` as a substring, causing Flutter to incorrectly exclude arm64
    from
    simulator builds when plugins only exclude arm64e.
    
    This adds a word boundary (\\barm64\\b) so that arm64e is no longer a
    false
    positive match, fixing simulator builds on Apple Silicon Macs.
    
    Also strengthens the existing test assertion to verify arm64 is NOT
    added
    to EXCLUDED_ARCHS when only arm64e is excluded by plugins.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [AI contribution guidelines] and understand my
    responsibilities, or I am not using AI tools.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    trizin authored Apr 10, 2026
    Configuration menu
    Copy the full SHA
    bf18e39 View commit details
    Browse the repository at this point in the history
Loading