[Win32] Don't warn on certain deprecated stdlib fns (#564)

cbracken · web-flow · commit 2c4c3a6c47a2 · 2022-04-14T18:40:01.000-07:00
Disable warnings about use of open, close, read, strdup, and some other deprecated functions that will almost certainly never be removed, that are found in third_party libraries. Issue: #59199
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
@@ -269,6 +269,12 @@ config("compiler") {
         assert(false, "unknown current_cpu " + current_cpu)
       }
     }
+
+    # Don't warn about open, close, read, and other deprecated stdlib functions.
+    defines += [
+      "_CRT_NONSTDC_NO_WARNINGS",
+      "_CRT_NONSTDC_NO_DEPRECATE",
+    ]
   }
 
   if (operator_new_alignment != "default" && is_clang) {

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,12 @@ config("compiler") {`
`269`	`269`	`assert(false, "unknown current_cpu " + current_cpu)`
`270`	`270`	`}`
`271`	`271`	`}`
	`272`	`+`
	`273`	`+ # Don't warn about open, close, read, and other deprecated stdlib functions.`
	`274`	`+ defines += [`
	`275`	`+ "_CRT_NONSTDC_NO_WARNINGS",`
	`276`	`+ "_CRT_NONSTDC_NO_DEPRECATE",`
	`277`	`+ ]`
`272`	`278`	`}`
`273`	`279`
`274`	`280`	`if (operator_new_alignment != "default" && is_clang) {`