This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix ColorFilter.matrix constness #9789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 11, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 11, 2019
flutter/engine@3b94410...bcde838 git log 3b94410..bcde838 --no-merges --oneline bcde838 Roll Wuffs and buildroot (flutter/engine#9791) 3b75979 fix ColorFilter.matrix constness (flutter/engine#9789) 3c9a22c Fall back to a fully qualified path to libapp.so if the library can not be loaded by name (flutter/engine#9762) 298a610 Roll fuchsia/sdk/core/mac-amd64 from XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC to CDbRdGJ3bu-aWMCZqN5VzfQqIBwDGL2wfFodWABKdCIC (flutter/engine#9790) 833f6b4 Roll src/third_party/skia f9fcf7ffa89a..7825d4983f90 (6 commits) (flutter/engine#9788) 1250c37 Add comments to differentiate two cache paths (flutter/engine#9721) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@3b94410...bcde838 git log 3b94410..bcde838 --no-merges --oneline bcde838 Roll Wuffs and buildroot (flutter/engine#9791) 3b75979 fix ColorFilter.matrix constness (flutter/engine#9789) 3c9a22c Fall back to a fully qualified path to libapp.so if the library can not be loaded by name (flutter/engine#9762) 298a610 Roll fuchsia/sdk/core/mac-amd64 from XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC to CDbRdGJ3bu-aWMCZqN5VzfQqIBwDGL2wfFodWABKdCIC (flutter/engine#9790) 833f6b4 Roll src/third_party/skia f9fcf7ffa89a..7825d4983f90 (6 commits) (flutter/engine#9788) 1250c37 Add comments to differentiate two cache paths (flutter/engine#9721) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're not allowed to check the length of anything but strings - the CFE allows it but that's a bug (dart-lang/sdk#35420).
Unfortunately, dropping const here would be a breaking change - we can still have the assert later, which may make the call stack confusing for people but is probably better than nothing.