This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix Picture.toImage return type check and api conform test. #9685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2019
This was referenced Jul 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 8, 2019
flutter/engine@3c51a7b...e695a51 git log 3c51a7b..e695a51 --no-merges --oneline e695a51 Add FLEDartProject for macOS embedding (flutter/engine#9672) 44f2f07 Roll src/third_party/skia e192c4ce5a33..829b6a0ff49f (1 commits) (flutter/engine#9705) d5f15d1 Roll src/third_party/skia de6758683abd..e192c4ce5a33 (2 commits) (flutter/engine#9703) e465329 Roll src/third_party/skia 2f62edf1ac5d..de6758683abd (1 commits) (flutter/engine#9700) 05966cd Roll src/third_party/skia 1d105080c423..2f62edf1ac5d (1 commits) (flutter/engine#9699) b132baa Ensure that platform messages without response handles can be dispatched. (flutter/engine#9698) 50d6228 fix Picture.toImage return type check and api conform test. (flutter/engine#9685) 001bb54 Roll src/third_party/skia 8063f6cca025..1d105080c423 (3 commits) (flutter/engine#9692) db4d683 Roll src/third_party/skia 857c9f955edb..8063f6cca025 (3 commits) (flutter/engine#9679) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@3c51a7b...e695a51 git log 3c51a7b..e695a51 --no-merges --oneline e695a51 Add FLEDartProject for macOS embedding (flutter/engine#9672) 44f2f07 Roll src/third_party/skia e192c4ce5a33..829b6a0ff49f (1 commits) (flutter/engine#9705) d5f15d1 Roll src/third_party/skia de6758683abd..e192c4ce5a33 (2 commits) (flutter/engine#9703) e465329 Roll src/third_party/skia 2f62edf1ac5d..de6758683abd (1 commits) (flutter/engine#9700) 05966cd Roll src/third_party/skia 1d105080c423..2f62edf1ac5d (1 commits) (flutter/engine#9699) b132baa Ensure that platform messages without response handles can be dispatched. (flutter/engine#9698) 50d6228 fix Picture.toImage return type check and api conform test. (flutter/engine#9685) 001bb54 Roll src/third_party/skia 8063f6cca025..1d105080c423 (3 commits) (flutter/engine#9692) db4d683 Roll src/third_party/skia 857c9f955edb..8063f6cca025 (3 commits) (flutter/engine#9679) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for the return type, and fix the Picture.toImage types to return a Future