This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Switch PlatformViewsController from Activity ref to Application ref. #9193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2019
flutter/engine@afb9d51...7826548 git log afb9d51..7826548 --no-merges --oneline 7826548 Align fuchsia and non-fuchsia tracing (flutter/engine#9199) 5ea125e Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193) fd4368c Skip golden tests on non-Linux OSes (flutter/engine#9198) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
…on ref. (flutter#9193)" (flutter#9211) This reverts commit 5ea125e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch PlatformViewsController from Activity ref to Application ref.
This change is being made to facilitate add-to-app use-cases where an Activity may come and go. We should be OK using the Application Context instead of an Activity.
I ran the webview plugin's sample project against a local engine with this change. It appeared to run fine.