This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Guard out-of-tree Fuchsia targets to fix in-tree build #8923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c8d714 to
453430c
Compare
chinmaygarde
approved these changes
May 9, 2019
Member
Author
|
Landing revert on red. |
Member
Author
|
Whoops. I thought this was the Dart roll revert PR. I suspect this is actually harmless to land while the revert actually goes through, though. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 10, 2019
flutter/engine@644db5a...f1f95f9 git log 644db5a..f1f95f9 --no-merges --oneline f1f95f9 Revert "Roll src/third_party/dart a0290f823c..c1e2df8f36 (3 commits)" (flutter/engine#8925) 27409dc [fuchsia] Guard out-of-tree Fuchsia targets to fix in-tree build (flutter/engine#8923) 6ed91ce Roll src/third_party/dart a0290f823c..c1e2df8f36 (3 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.