This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Prevent redundant layouts when floor(width) is the same #8867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
May 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 10, 2019
flutter/engine@710e9ed...3822aec git log 710e9ed..3822aec --no-merges --oneline 3822aec Prevent redundant layouts when floor(width) is the same (flutter/engine#8867) 0bc6dc9 Platform_views gesture: let flutter view controller be the media to pass the touches. (flutter/engine#8685) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass two widths that
floorto the same value, and end up doing a redundant layout. This change prevents this from happening. It is incorrect to always perform layout if a non-integer value is passed as width.This is purposefully missing a test, as we are currently discussing removing the
floorbehavior altogether, and a test would be cementing in likely unnecessary behavior.