This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Download the Fuchsia SDK and toolchain in a gclient hook. #8794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Apr 30, 2019
Contributor
Author
|
Updated. PTAL. |
zanderso
approved these changes
Apr 30, 2019
Contributor
Author
|
@pylaligand @Hixie @abarth: What are the licensing implications of pulling in the Fuchsia toolchains & SDK? That's what the license script is failing on ATM. |
Contributor
|
There is a LICENSE file at the root of the SDK that you can refer to. |
Downloads into //fuchsia/sdk and //fuchsia/toolchain. //fuchsia is in the buildroot gitignore.
db64b5e to
189ecc0
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 3, 2019
flutter/engine@39a950e...4808446 git log 39a950e..4808446 --no-merges --oneline 4808446 Remove asserts and add BuildConfig (flutter/engine#8821) c97bd45 Download the Fuchsia SDK and toolchain in a gclient hook. (flutter/engine#8794) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloads into //fuchsia/sdk and //fuchsia/toolchain. //fuchsia is in the buildroot gitignore.