This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Increase the memory usage estimate for EngineLayer" #8738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 30fb4a6.
Contributor
Author
|
Landing this TBR to unblock google3 rolls. Seems convincing to me that this did not resolve the intended problem and has introduced new regressions. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2019
flutter/engine@26b30a4...1a8534c git log 26b30a4..1a8534c --no-merges --oneline 1a8534c Revert "Increase the memory usage estimate for EngineLayer (#8700)" (flutter/engine#8738) d2703b4 Roll src/third_party/skia a1ab899e9e3f..2444c0e9aa23 (2 commits) (flutter/engine#8739) 0f47ab6 Roll src/third_party/skia 46d0f9aad1e6..a1ab899e9e3f (2 commits) (flutter/engine#8737) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8700
This causes the perf regression noted in flutter/flutter#31590
The bug it was intended to fix also reports that this value may not be high enough and the memory leak is still showing up on some phones.