This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Plumb arguments from Settings to Dart entrypoint #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 23, 2019
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
A unit-test in the runtime_unittests target (see dart_isolate_unittests.cc) would be appreciated.
2b63956 to
597f251
Compare
597f251 to
0ea80f3
Compare
Member
Author
|
Added test. Awaiting manual engine -> framework roll. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2019
…8710) (#31613) flutter/engine@e44c5d9...3a29e6a git log e44c5d9..3a29e6a --no-merges --oneline 3a29e6a Plumb arguments from Settings to Dart main() (flutter/engine#8710) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
dart_entrypoint_argsfield to Settings and plumbs it as aList<String>to the Dart entrypoint. This is primarily for FL-243, but may be generally useful for desktop as well.