Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@justinmc
Copy link
Contributor

Closes flutter/flutter#15300

See discussion here: flutter/flutter#30988

Originally created tightWidth in this engine PR: #8530

@justinmc justinmc self-assigned this Apr 23, 2019
@justinmc justinmc force-pushed the text-wrap-width-2 branch from 96dcb34 to 4b0bceb Compare April 23, 2019 20:56
@justinmc justinmc requested a review from HansMuller April 23, 2019 21:02
Copy link

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc force-pushed the text-wrap-width-2 branch from f927d33 to efc9482 Compare April 23, 2019 23:18
@justinmc justinmc merged commit 3493dcf into flutter:master Apr 26, 2019
@justinmc justinmc deleted the text-wrap-width-2 branch April 26, 2019 23:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 27, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 27, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 27, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 27, 2019
flutter/engine@7f753f8...3b1bebf

git log 7f753f8..3b1bebf --no-merges --oneline
3b1bebf Roll src/third_party/skia e178c0586cd6..d7082a5805c8 (1 commits) (flutter/engine#8766)
5846027 Roll src/third_party/skia 3349fb0195ff..e178c0586cd6 (1 commits) (flutter/engine#8763)
3493dcf Rename tightWidth to longestLine (flutter/engine#8706)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Paragraph.longestLine (width at which we wrapped the longest line)

3 participants