This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Test saving compilation traces. #8618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbaranov
approved these changes
Apr 18, 2019
| } catch (exception) { | ||
| print("Could not save compilation trace: " + exception); | ||
| } | ||
| NotifyResult(trace != null && trace.length > 0); |
Contributor
There was a problem hiding this comment.
Here is the test that I mentioned that does more thorough check on the output: https://github.com/flutter/flutter/blob/d2790bd2bbf1851db2359026df7bca38e255b9d3/packages/flutter/test/foundation/service_extensions_test.dart#L655
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2019
flutter/engine@876c4c3...8b5a50c git log 876c4c3..8b5a50c --no-merges --oneline 8b5a50c Test saving compilation traces. (flutter/engine#8618) 7d3caf8 Avoid leaking the VM in runtime_unittests and update failing tests. (flutter/engine#8626) 91b7107 Revert "Add a unit test for PhysicalShapeLayer (#8616)" (flutter/engine#8627) 8b667b0 Add a unit test for PhysicalShapeLayer (flutter/engine#8616) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.