This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove call to SkFont::setLinearMetrics #8612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular call doesn't do anything since the default is false anyway. In addition Skia is looking to remove this flag since setting it to true is now synonymous with setting the hinting to none.
jason-simmons
approved these changes
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2019
flutter/engine@523a9a9...7679474 git log 523a9a9..7679474 --no-merges --oneline 7679474 Roll src/third_party/skia 6f9047027be3..14c90c1ca218 (5 commits) (flutter/engine#8619) d8aa6bc Fix typo in comment (flutter/engine#8617) 8ff631f Rename flow namespace to flutter (flutter/engine#8615) 0534b6a Roll src/third_party/dart bc99f1ca28..7b9ab9f353 (5 commits) b767e4d Roll src/third_party/skia 5155e09d1466..6f9047027be3 (5 commits) (flutter/engine#8613) c5d1ba9 Remove call to SkFont::setLinearMetrics (flutter/engine#8612) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular call doesn't do anything since the default is false
anyway. In addition Skia is looking to remove this flag since setting it
to true is now synonymous with setting the hinting to none.