This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Text inline widget LibTxt/dart:ui implementation #8207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We now track and pass the indicies of the us-added placeholder U+FFFC so it is now safe to use U+FFFC in text and we do not need to do replacement anymore |
Contributor
|
Oh ok, cool. |
goderbauer
reviewed
May 10, 2019
goderbauer
reviewed
May 10, 2019
| /// * For a 30x50 placeholder that sits completely on top of the alphabetic baseline, use: | ||
| /// `addPlaceholder(30, 50, PlaceholderAlignment.aboveBaseline, baseline: TextBaseline.alphabetic)`. | ||
| /// * For a 30x50 placeholder with 40 pixels above and 10 pixels below the alphabetic baseline, use: | ||
| /// `addPlaceholder(30, 50, PlaceholderAlignment.baseline, baseline: TextBaseline.alphabetic, baselineOffset: 40)`. |
Member
There was a problem hiding this comment.
(for extra bonus points) I kinda wish these examples had little images embedded showcasing what all this would look like.
goderbauer
approved these changes
May 29, 2019
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM for the dart files in this PR modulo a handful of doc nits.
goderbauer
reviewed
May 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 3, 2019
flutter/engine@f9ce016...008090b git log f9ce016..008090b --no-merges --oneline 008090b Extracted PlatformViewsChannel from PlatformViewsController. (flutter/engine#7847) a4abfb2 Text inline widget LibTxt/dart:ui implementation (flutter/engine#8207) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a series of work to add text inline widgets, to fix flutter/flutter#2022.
This PR adds LibTxt and dart:ui support for embedding widgets inline into text.
Specifically, LibTxt's responsibility is to leave an open space where the widget will then be drawn into by the framework.
The API exposed for accomplishing this is:
ParagraphBuilder.AddWidget(width, height, baseline);adds a representation of a widget to the paragraphParagraph.GetBoxesForWidgets();returns a list of rects/boxes that bound all widgets in the paragraph.This PR should only make non-API-breaking additions and should be safe to land with no immediate framework changes.