Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

Some embedders may have to wait on fences asynchronously before committing
contents. This allows them to post a task onto the engine managed thread used
for rendering.

Some embedders may have to wait on fences asynchronously before committing
contents. This allows them to post a task onto the engine managed thread used
for rendering.
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit 3c8ef04 into flutter:master Mar 9, 2019
@chinmaygarde chinmaygarde deleted the post_render_task branch March 9, 2019 00:30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 9, 2019
flutter/engine@87edd94...c48774c

git log 87edd94..c48774c --no-merges --oneline
c48774c Roll src/third_party/dart 571ea80e11..2fb6cd9f5f (122 commits) (flutter/engine#8086)
3c8ef04 Allow embedders to post tasks onto the render thread. (flutter/engine#8089)
1d10e0e Guard against NewAPI failures (flutter/engine#8048)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants