This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure dart2js and kernel worker snapshots are copied out of gen dir #7692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Feb 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
This was referenced Feb 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
This was referenced Feb 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
matthew-carroll
pushed a commit
to matthew-carroll/flutter
that referenced
this pull request
Feb 5, 2019
cc27caf Implemented Dark Mode for Android (flutter#25525) ([flutter/engine#7488](flutter/engine#7488)) 9c05cbc Roll src/third_party/dart b53dceadaa..5823be65af (5 commits) 5823be65af [vm/compiler] Continued graph checker development (reland) 8231cdb7a3 [gardening] Update status for issue 35854 db7f848632 [vm] Remove dead BigInt code. 35ab1755f4 Support more type propagation for code-as-ui features 569ee07f91 [vm] Cleanup class finalization checks ec5e6f6 Ensure dart2js and kernel worker snapshots are copied out of gen dir ([flutter/engine#7692](flutter/engine#7692)) 8b5fa65 Roll src/third_party/skia 50ea3c06b80f..2d35a1c87553 (6 commits) ([flutter/engine#7693](flutter/engine#7693))
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 5, 2019
matthew-carroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2019
* Bugfix: Add platformBrightness to TestWindow. * Manual engine roll: cc27caf Implemented Dark Mode for Android (#25525) ([flutter/engine#7488](flutter/engine#7488)) 9c05cbc Roll src/third_party/dart b53dceadaa..5823be65af (5 commits) 5823be65af [vm/compiler] Continued graph checker development (reland) 8231cdb7a3 [gardening] Update status for issue 35854 db7f848632 [vm] Remove dead BigInt code. 35ab1755f4 Support more type propagation for code-as-ui features 569ee07f91 [vm] Cleanup class finalization checks ec5e6f6 Ensure dart2js and kernel worker snapshots are copied out of gen dir ([flutter/engine#7692](flutter/engine#7692)) 8b5fa65 Roll src/third_party/skia 50ea3c06b80f..2d35a1c87553 (6 commits) ([flutter/engine#7693](flutter/engine#7693))
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* Bugfix: Add platformBrightness to TestWindow. * Manual engine roll: cc27caf Implemented Dark Mode for Android (flutter#25525) ([flutter/engine#7488](flutter/engine#7488)) 9c05cbc Roll src/third_party/dart b53dceadaa..5823be65af (5 commits) 5823be65af [vm/compiler] Continued graph checker development (reland) 8231cdb7a3 [gardening] Update status for issue 35854 db7f848632 [vm] Remove dead BigInt code. 35ab1755f4 Support more type propagation for code-as-ui features 569ee07f91 [vm] Cleanup class finalization checks ec5e6f6 Ensure dart2js and kernel worker snapshots are copied out of gen dir ([flutter/engine#7692](flutter/engine#7692)) 8b5fa65 Roll src/third_party/skia 50ea3c06b80f..2d35a1c87553 (6 commits) ([flutter/engine#7693](flutter/engine#7693))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only depending on the rules does not copy the snapshots to the correct sdk location. We also cannot add a rule to do this because it has a collision with the sdk rule (even though that particular rule does not run), and we cannot yet use the full sdk build due to issues in the dartdevc rules.
Instead, copy each snapshot file to bin/snapshots/flutter_$name. Since the flutter tool will use the snapshots directly, we don't need the bash/bat scripts and the name can be different.