This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Pass null instead of 'none' locale" #6622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Oct 20, 2018
Contributor
|
What's the next logical step to fix flutter/flutter#23241? Revert 35340ce? |
Contributor
Author
|
I need to figure out what else can modify widgets/app.dart locale because it seems that before my change, locale getter was able to come up with some non-null locale. I think locale being null is one of the ways the code currently decides if resolutions were successful or not, as well as other places, so simply providing null breaks all of that. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2018
flutter/engine@58cdd53...ce36d85 git log 58cdd53..ce36d85 --no-merges --oneline ce36d85 Revert "Pass null instead of 'none' locale" (flutter/engine#6622) 9de880c Revert "Roll buildtools to 759274dd801b2f78ae0c4066101d0beca27ffc9a" (flutter/engine#6621) 8cb3965 Properly gate android API < 21 and remove extraneous data array. (flutter/engine#6619) 2091c0d Update Dart version in Dockerfile (flutter/engine#6618) 739d66e Don't attempt to build any platform target on Fuchsia. (flutter/engine#6617) 7d49036 Roll Dart to 45f9462398ae7d2e80acd79d3f9c32c7ca6f6f97 (flutter/engine#6616) 6c84c5f Pass null instead of 'none' locale (flutter/engine#6613) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Contributor
|
Can we fall back to |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2018
flutter/engine@58cdd53...4c79e42 git log 58cdd53..4c79e42 --no-merges --oneline 4c79e42 Roll src/third_party/skia 69083b2b626b..b9998cdceec7 (9 commits) (flutter/engine#6620) ce36d85 Revert "Pass null instead of 'none' locale" (flutter/engine#6622) 9de880c Revert "Roll buildtools to 759274dd801b2f78ae0c4066101d0beca27ffc9a" (flutter/engine#6621) 8cb3965 Properly gate android API < 21 and remove extraneous data array. (flutter/engine#6619) 2091c0d Update Dart version in Dockerfile (flutter/engine#6618) 739d66e Don't attempt to build any platform target on Fuchsia. (flutter/engine#6617) 7d49036 Roll Dart to 45f9462398ae7d2e80acd79d3f9c32c7ca6f6f97 (flutter/engine#6616) 6c84c5f Pass null instead of 'none' locale (flutter/engine#6613) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2018
flutter/engine@58cdd53...cadf440 git log 58cdd53..cadf440 --no-merges --oneline cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter/engine#6626) 4c79e42 Roll src/third_party/skia 69083b2b626b..b9998cdceec7 (9 commits) (flutter/engine#6620) ce36d85 Revert "Pass null instead of 'none' locale" (flutter/engine#6622) 9de880c Revert "Roll buildtools to 759274dd801b2f78ae0c4066101d0beca27ffc9a" (flutter/engine#6621) 8cb3965 Properly gate android API < 21 and remove extraneous data array. (flutter/engine#6619) 2091c0d Update Dart version in Dockerfile (flutter/engine#6618) 739d66e Don't attempt to build any platform target on Fuchsia. (flutter/engine#6617) 7d49036 Roll Dart to 45f9462398ae7d2e80acd79d3f9c32c7ca6f6f97 (flutter/engine#6616) 6c84c5f Pass null instead of 'none' locale (flutter/engine#6613) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6613.
Passing null has further reaching repercussions and will take more time to properly fix.