This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use Skia normalize again after Skia precision fix. #6121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 30, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2018
flutter/engine@252da48...dc7b5eb git log 252da48..dc7b5eb --no-merges --oneline dc7b5eb Use Skia normalize again after Skia precision fix. (flutter/engine#6121) 1c76824 entering a character with a selection deletes the selection (flutter/engine#6113) 9fc355d Roll src/third_party/skia cd7907b57d76..7ed0eae0cd13 (1 commits) (flutter/engine#6120) 6586016 Roll src/third_party/skia f7c723c93d26..cd7907b57d76 (1 commits) (flutter/engine#6119) 1fa5fe6 Roll src/third_party/skia eb0bb732f43f..f7c723c93d26 (3 commits) (flutter/engine#6118) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2018
flutter/engine@252da48...dc7b5eb git log 252da48..dc7b5eb --no-merges --oneline dc7b5eb Use Skia normalize again after Skia precision fix. (flutter/engine#6121) 1c76824 entering a character with a selection deletes the selection (flutter/engine#6113) 9fc355d Roll src/third_party/skia cd7907b57d76..7ed0eae0cd13 (1 commits) (flutter/engine#6120) 6586016 Roll src/third_party/skia f7c723c93d26..cd7907b57d76 (1 commits) (flutter/engine#6119) 1fa5fe6 Roll src/third_party/skia eb0bb732f43f..f7c723c93d26 (3 commits) (flutter/engine#6118) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
GaryQian
added a commit
that referenced
this pull request
Sep 4, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
)" (flutter#6122) This reverts commit dc7b5eb.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
)" (flutter#6122) This reverts commit dc7b5eb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back to using skia SkPoint3.normalize() after a precision patch on Skia.