This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delay the removal of the onDrawListener. #6052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Android O removing the ViewTreeObserver.onDrawListener from the listener call crashes. Instead we post a runnable to remove it.
jason-simmons
approved these changes
Aug 20, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2018
flutter/engine@c23690f...c06432d git log c23690f..c06432d --no-merges --oneline c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2018
flutter/engine@c23690f...aba09a2 git log c23690f..aba09a2 --no-merges --oneline aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2018
flutter/engine@c23690f...e26643f git log c23690f..e26643f --no-merges --oneline e26643f Rename clipMode to clipBehavior in compositing.dart (flutter/engine#6053) aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2018
flutter/engine@c23690f...5903a08 git log c23690f..5903a08 --no-merges --oneline 5903a08 Roll Dart to 69fce633b72e158f5ac553cf3f0f4fcd0f7c735a (flutter/engine#6055) e26643f Rename clipMode to clipBehavior in compositing.dart (flutter/engine#6053) aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2018
flutter/engine@c23690f...2ff1626 git log c23690f..2ff1626 --no-merges --oneline 2ff1626 Support LTR/RTL layout directions for embedded Android views. (flutter/engine#6057) d687f9d Roll src/third_party/skia 4f41dcf7d99a..8bbd3fedf55b (4 commits) (flutter/engine#6056) 5903a08 Roll Dart to 69fce633b72e158f5ac553cf3f0f4fcd0f7c735a (flutter/engine#6055) e26643f Rename clipMode to clipBehavior in compositing.dart (flutter/engine#6053) aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2018
flutter/engine@c23690f...5ff4354 git log c23690f..5ff4354 --no-merges --oneline 5ff4354 Clear the line baselines when doing each pass of layout (flutter/engine#6058) 2ff1626 Support LTR/RTL layout directions for embedded Android views. (flutter/engine#6057) d687f9d Roll src/third_party/skia 4f41dcf7d99a..8bbd3fedf55b (4 commits) (flutter/engine#6056) 5903a08 Roll Dart to 69fce633b72e158f5ac553cf3f0f4fcd0f7c735a (flutter/engine#6055) e26643f Rename clipMode to clipBehavior in compositing.dart (flutter/engine#6053) aba09a2 Roll src/third_party/skia 7c42e01cedb9..4f41dcf7d99a (5 commits) (flutter/engine#6054) c06432d Delay the removal of the onDrawListener. (flutter/engine#6052) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android O removing the ViewTreeObserver.onDrawListener from the
listener call crashes. Instead we post a runnable to remove it.