This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add message encoding/decoding utility to FML. #6017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Resize(NextPowerOfTwoSize(size)); | ||
| } | ||
|
|
||
| bool Message::Resize(size_t size) { |
Member
There was a problem hiding this comment.
Can buffer_ be changed to a std::vector<uint8_t> instead of implementing resize logic here?
Contributor
Author
There was a problem hiding this comment.
I could not figure out how to deal with allocation errors on malloc and realloc when using the std::vector container. This implementation handles those edge cases and the FML_WARN_UNUSED_RESULT makes it hard to ignore those errors.
Member
There was a problem hiding this comment.
vector::resize will throw on an allocation failure. Also, many allocators will always report success, followed by a segfault when the caller tries to use unavailable memory.
Either way is fine though
jason-simmons
approved these changes
Aug 15, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e54bc4e...7e39999 git log e54bc4e..7e39999 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025) 2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022) 2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021) 2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019) 2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016) 2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014) 2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011) 2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013) 2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010) 2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008) 2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003) 2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002) 2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000) 2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999) 2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982) 2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998) 2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997) 2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972) 2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996) 2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993) 2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992) 2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988) 2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987) 2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e54bc4e...829e475 git log e54bc4e..829e475 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025) 2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022) 2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021) 2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019) 2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016) 2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014) 2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011) 2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013) 2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010) 2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008) 2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003) 2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002) 2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000) 2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999) 2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982) 2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998) 2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997) 2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972) 2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996) 2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993) 2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992) 2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988) 2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987) 2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e54bc4e...c09116a git log e54bc4e..c09116a --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025) 2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022) 2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021) 2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019) 2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016) 2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014) 2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011) 2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013) 2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010) 2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008) 2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003) 2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002) 2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000) 2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999) 2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982) 2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998) 2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997) 2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972) 2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996) 2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993) 2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992) 2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988) 2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987) 2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e54bc4e...9c0c620 git log e54bc4e..9c0c620 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025) 2018-08-15 kustermann.martin@gmail.com Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022) 2018-08-14 chinmaygarde@gmail.com Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021) 2018-08-14 chinmaygarde@gmail.com Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019) 2018-08-14 jason-simmons@users.noreply.github.com Log Tonic errors with FML_LOG (flutter/engine#6015) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016) 2018-08-14 jason-simmons@users.noreply.github.com Detach the resource context before shutting down the IO thread (flutter/engine#6009) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014) 2018-08-15 1751188+NikoYuwono@users.noreply.github.com Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011) 2018-08-14 jamesderlin@users.noreply.github.com Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986) 2018-08-14 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013) 2018-08-14 kustermann.martin@gmail.com Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010) 2018-08-13 jason-simmons@users.noreply.github.com Do not log unwind errors during isolate shutdown (flutter/engine#6008) 2018-08-13 chinmaygarde@gmail.com Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004) 2018-08-13 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003) 2018-08-12 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002) 2018-08-11 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000) 2018-08-10 stanislav@gmail.com Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999) 2018-08-10 jbauman@google.com Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982) 2018-08-10 jbauman@google.com Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998) 2018-08-10 chinmaygarde@gmail.com Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997) 2018-08-10 nathanrogers@google.com Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972) 2018-08-10 stanislav@gmail.com Fix codepush breakage caused by flutter#5954. (flutter/engine#5996) 2018-08-10 amirh@users.noreply.github.com Cast MotionEvent timestamps to Number. (flutter/engine#5994) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993) 2018-08-10 tvolkert@users.noreply.github.com Reference platform_strong.dill, not platform.dill (flutter/engine#5992) 2018-08-10 jason-simmons@users.noreply.github.com Update to FreeType 2.9.1 (flutter/engine#5991) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989) 2018-08-10 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988) 2018-08-10 kustermann.martin@gmail.com Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987) 2018-08-09 a-siva@users.noreply.github.com Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e3687f7...2f19645 git log e3687f7..2f19645 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 chinmaygarde@gmail.com Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...36aa0ed git log e3687f7..36aa0ed --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 chinmaygarde@gmail.com Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...3280fc3 git log e3687f7..3280fc3 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 chinmaygarde@gmail.com Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...a5204c9 git log e3687f7..a5204c9 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-16 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64703d11a92a..767fddfcce61 (1 commits) (flutter/engine#6031) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 chinmaygarde@gmail.com Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 16, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...4ee6489 git log e3687f7..4ee6489 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-16 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 767fddfcce61..cbd83bbd77d1 (1 commits) (flutter/engine#6032) 2018-08-16 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 64703d11a92a..767fddfcce61 (1 commits) (flutter/engine#6031) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 chinmaygarde@gmail.com Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 chinmaygarde@gmail.com Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+skia-flutter-autoroll@users.noreply.github.com Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 liyuqian@google.com Update docker image tag and README (flutter/engine#5995) 2018-08-15 chinmaygarde@gmail.com Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.