This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manual Skia roll from 79a7b95e32fe to 0aec6f7bfbc8 #57134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 12:50
flar
approved these changes
Dec 11, 2024
Contributor
flar
left a comment
There was a problem hiding this comment.
Looks good to me. We should eventually follow their example and refuse to build an empty vertices object.
Contributor
|
auto label is removed for flutter/engine/57134, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
wait why is this impeller test failing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2024
flutter/engine@92de3d0...847deb2 2024-12-12 bryanoltman@gmail.com Cast ::GetLastError to int (flutter/engine#57113) 2024-12-12 jonahwilliams@google.com Manual Skia roll from 79a7b95e32fe to 0aec6f7bfbc8 (flutter/engine#57134) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
) skia-flutter-autoroll Member [skia-flutter-autoroll](https://github.com/skia-flutter-autoroll) commented [1 hour ago](flutter/engine#57131 (comment)) https://skia.googlesource.com/skia.git/+log/79a7b95e32fe..0aec6f7bfbc8 2024-12-11 [jvanverth@google.com](mailto:jvanverth@google.com) [graphite] Force ordered recordings in nanobench. 2024-12-11 [nicolettep@google.com](mailto:nicolettep@google.com) [graphite] Rename snippet requirement flag to more clearly express purpose 2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Roll Skia Infra from a42d0274444b to 0849df86a686 (7 revisions) 2024-12-11 [vigneshv@google.com](mailto:vigneshv@google.com) Revert "Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec""" 2024-12-11 [fmalita@google.com](mailto:fmalita@google.com) Clamp index values in SkVertices factories 2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Manual roll vulkan-deps from b5e5616193ec to 769bd5140c26 (8 revisions) 2024-12-11 [skia-autoroll@skia-public.iam.gserviceaccount.com](mailto:skia-autoroll@skia-public.iam.gserviceaccount.com) Manual roll Dawn from 052be48b9a1a to 01d91c0571a2 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [jonahwilliams@google.com](mailto:jonahwilliams@google.com),[kjlubick@google.com](mailto:kjlubick@google.com),[maxhudnell@google.com](mailto:maxhudnell@google.com) on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skia-flutter-autoroll
Member
skia-flutter-autoroll commented 1 hour ago
https://skia.googlesource.com/skia.git/+log/79a7b95e32fe..0aec6f7bfbc8
2024-12-11 jvanverth@google.com [graphite] Force ordered recordings in nanobench.
2024-12-11 nicolettep@google.com [graphite] Rename snippet requirement flag to more clearly express purpose
2024-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a42d0274444b to 0849df86a686 (7 revisions)
2024-12-11 vigneshv@google.com Revert "Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec"""
2024-12-11 fmalita@google.com Clamp index values in SkVertices factories
2024-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b5e5616193ec to 769bd5140c26 (8 revisions)
2024-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 052be48b9a1a to 01d91c0571a2 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md