This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll dart to 84ca27a09ebd6a65cd23ee52d835d89cbe06c574. #5700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since last roll: ``` 84ca27a Fix File::OpenUri on Windows. 5403f65 Merge existing metadata into new incrementally compiled components. 3cc0a9a Another fix for a race in a test. 4aacaeb [vm/compiler] Fix handling of exception-throwing instructions in DSE 4ff4620 Adjust status lines for safari (take 2) c5c18a0 Introduce percent decoding in File::OpenUri. 550f294 Move some analysis to analyzer-analysis-server-linux and make analyzer-analysis-server-linux a try bot. f5de04f Apply resolution to directive annotations. 6d328b7 Correctly parse dartdoc before abstract class 25969b2 Store resolution for abstract class constructor invocation. 973f73b Handle invalid types from front end. bab152a Fix default in gardening tools 007dcd4 Upgrade package:http to 0.11.3+17. 2519892 Address a race condition in a test. ed0ccc7 Add more error message mappings f0560a8 Add error code ArgumentTypeNotAssignable to improve messaging (issue 33712) 660b8b7 [fuchsia] Update path to timezone service acd8f34 Update safari status 4ab0827 [gn] Remove dart_test_bootfs 1c673b1 Include bounds in type literals 3a1b09d Fix for bug flutter#33660 810cdf8 Add tests for bug flutter#33660 ac05595 Memory file system returns Uint8List from readAsBytes d26dba1 More positions in dart2 constant evaluator eafc52a Add a recovery test 8be1ddb Throw FileSystemException from _FileSystemEntityAdaptor when the file does not exist. 98391f2 [vm] Refactoring: move StreamingScopeBuilder out of kernel_binary_flowgraph 6dfc4ef Remove old dart2analyzer not strong status file entries. 32d208d Revert "Adjust status lines for safari" 5da24bb Adjust status lines for safari c1f6c9d Fix dart2js-hostassert configuration and enable it on the CQ 1717371 Move InferredData to GlobalTypeInferenceResults 403e7c8 Use DataComputer class to implement equivalence based tests 5dbf6da Remove generics where only ir.Node is used da9705b Split compileLoadedLibraries 04168fa Move more methods to ClassHierarchy. a4c47af Fix global-inference bug. 3e33c3d Eliminate analysis warnings in pkg/ code. 72f3abc Fix force-strong flag. e3323ae [vm/inliner] Inline typed data on 32-bit archs. f5a3af4 [VM] A const bool.fromEnvironment() with an explicit defaultValue of `null` should default to `null` 1a08800 Run analyzer --use-fasta-parser on the language2 tests; update status file. aa6dc1e [fasta] Resolve redirecting factories invocations after bodies are built 31cd00b Mark the analysis server integration tests as slow. 65ee951 Force tests to fail pending implementation. d52555c Update the changelog for analyzer changes. d6cf9b4 Deprecate and remove the implementation of an older flag. 609a191 Basic implementation of MOVE_FILE for files 149c5a0 Improve formatting of errors in golden files a600171 Update expectations after parser updates 7570fb8 [fasta] Set parent of annotations in BodyBuilder.finishMetadata. e8ff3d5 Deprecate and ignore the --strong flag on dartanalyzer. a5b8ed1 Have dart2analyzer no longer use the --no-preview-dart-2 flag in test.py. 58e7402 Initial attempt to analyze stack traces a07b2a1 Changed all warnings to errors in the language specification. 5b5e36f Remove use of deprecated methods and constants. 1400cf6 Add named configurations to test matrix. 5d2405f Update the status file for slow tests. 9871ad2 [infra] Move fasta legacy mode SDK tests to their own builder bb69cc1 Add ClassHierarchy to share code between J/KClosedWorld (second attempt) 148013f Re-add tests for MOVE_FILE refactoring. 9873f04 Update service test to not be different in sync async mode dbd97fb Prep for analyzer 0.32.3, front_end 0.1.3, kernel 0.3.3 6e8332b Remove older analyzer bots. eeb5449 More slow test status file updates c339846 [kernel] Move util.dart from bin to lib. 11123b7 Adjust status lines for firefox 620ab34 [vm] Implement reading of parameter annotations from kernel 7d7e39a [build] Move dart2js run for Observatory from python to GN 3c5fe3c Prevent npe when constructor cannot be resolved d50fa68 Update strong status in host-checked mode 6218c0f Mark analyzer tests as slow. f39eaf9 [vm] Refactoring: remove dependency of StreamingScopeBuilder on StreamingFlowGraphBuilder d5ccb53 Remove more uses of isInstanceOf 7007137 Adjustments to dart2js test matrix. 45eee81 Check another case of StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC. 4c789e9 Support the instantiation of abstract constructors d3b4ba3 Revert "Fix flutter#32227 export dynamic from dart:core in analyzer." aa93fa1 Update documentation of --host-checked. afaca9f Use field for class hierarchy map 46bfa72 Have the regular analyzer bots test in dart 2 mode. 90e9fec Add changelog entry for language change on int literals 8c63d57 [vm] Refactoring: move out classes independent of StreamingFlowGraphBuilder aa00933 Update test matrix for dart2js 5352554 Add tests for instance create of an abstract generic class 33f58d5 Add dump-info end to end test 98a2e90 [vm] Combine internal and external allocation into one allocation limit. 2876159 Resolve arguments and type arguments for unresolved invocations. c99268f Replace handleUnrecoverableError with handleRecoverableError 0ccdc3e Reland: [dart:io] Adds Socket.startConnect c9fd951 Add file path to ResolutionApplier error message fb762be Update dart_style to version 1.1.1 in DEPS db7085a Rename UnresolvedTargetInvocation. b803d74 Adjusted errors for FutureOr in class headers c407e83 Delete duplicate key "configurations" in test_matrix.json b303f5a Add flag --named-configuration (-n) to test.py options. 22b9847 [analyzer][cfe] Don't crash on converting errors with Severity.context 4fd0404 Adjusted circularity prevention rule for type variable subtyping 1467909 Call _completeOnAsyncReturn instead of .complete directly b7b24e9 Update dart2js-strong status across several suites 11e0015 Update analysis options files. ed6c096 Remove old entries from pkg/pkg.status. 30807fe [VM interpreter] Fix InterpretCall stub. The stub was marking the thread as executing VM code too early, since the slow path of AllocateArray (called via PushArrayOfArguments) calls into the runtime. With this fix, DeltaBlueClosures can run in fully interpreted mode. 10c13e0 - deprecate strong-mode: options - move those settings to the language: options settings - ignore strong-mode: false in the analysis options file 3a22666 Clearing a LinkedHashMap should not do big allocations adb4b4a Remove another call to handleUnrecoverableError fd26d67 Added getLegacyStats until Chrome fully supports new getStats() API. ```
liyuqian
approved these changes
Jul 9, 2018
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jul 11, 2018
Includes: * flutter/engine@fed2ea458 Revert "Remove vmservice_io.main from entry points. (flutter/engine#5625)" (flutter#5711) * flutter/engine@958d2cfc5 Remove trailing white spaces (flutter/engine#5708) * flutter/engine@6db0cc9da Roll src/third_party/skia 1d784ceafa9e..c69c4410be7d (13 commits) (flutter/engine#5709) * flutter/engine@494562442 Roll src/third_party/skia 418e658a6922..1d784ceafa9e (10 commits) (flutter/engine#5707) * flutter/engine@cb27dab2b Roll src/third_party/skia 6d98257725b5..418e658a6922 (1 commits) (flutter/engine#5706) * flutter/engine@2981cc7a3 Roll src/third_party/skia e0a9962b12ad..6d98257725b5 (1 commits) (flutter/engine#5704) * flutter/engine@ad4197280 Roll src/third_party/skia 8fe31406e980..e0a9962b12ad (3 commits) (flutter/engine#5703) * flutter/engine@3b6dedb86 Add anti-alias switch to canvas clip calls (flutter/engine#5670) * flutter/engine@d9a831c55 Roll dart to 84ca27a09ebd6a65cd23ee52d835d89cbe06c574. (flutter/engine#5700) * flutter/engine@d5fce84be revert change to app delegate that wont build on earlier xcodes (flutter/engine#5702) * flutter/engine@45db8f7c5 Roll src/third_party/skia d48897b576e9..8fe31406e980 (4 commits) (flutter/engine#5701) * flutter/engine@d217a9512 Remove cullRect calculation on TransformLayers with a perspective transform. (flutter/engine#5693) * flutter/engine@13d801ac2 Roll src/third_party/skia 1354048c8fa8..d48897b576e9 (8 commits) (flutter/engine#5699) * flutter/engine@1644f3589 Roll src/third_party/skia 373224c9ab3a..1354048c8fa8 (1 commits) (flutter/engine#5698) * flutter/engine@4da7d44f3 Roll src/third_party/skia a391c72a2057..373224c9ab3a (1 commits) (flutter/engine#5697) * flutter/engine@a36207f35 Roll src/third_party/skia 0dd98a59df63..a391c72a2057 (1 commits) (flutter/engine#5696) * flutter/engine@cf14ca0f7 Roll src/third_party/skia a717ca970b25..0dd98a59df63 (1 commits) (flutter/engine#5695) * flutter/engine@89cd29fb1 Roll src/third_party/skia dd962a95c5f2..a717ca970b25 (1 commits) (flutter/engine#5694) * flutter/engine@f52955c25 Roll src/third_party/skia bcc3aec00422..dd962a95c5f2 (1 commits) (flutter/engine#5692) * flutter/engine@6e6512287 Roll src/third_party/skia 4f6ea65f66c9..bcc3aec00422 (2 commits) (flutter/engine#5691) * flutter/engine@e3347680c Roll src/third_party/skia a50205fca5f7..4f6ea65f66c9 (2 commits) (flutter/engine#5690) * flutter/engine@8aa9a8158 Roll src/third_party/skia 6667fb123911..a50205fca5f7 (3 commits) (flutter/engine#5689) * flutter/engine@3c4bf8de3 Roll src/third_party/skia 3d3d8841ff86..6667fb123911 (1 commits) (flutter/engine#5688) * flutter/engine@f5f15b78b Roll src/third_party/skia b95bbba308b9..3d3d8841ff86 (1 commits) (flutter/engine#5687) * flutter/engine@31bd1e29a Roll src/third_party/skia 20b824d9fe49..b95bbba308b9 (1 commits) (flutter/engine#5686) * flutter/engine@37e96b9e6 Roll src/third_party/skia 53f5db5e9833..20b824d9fe49 (1 commits) (flutter/engine#5685) * flutter/engine@b04fc96c2 Roll src/third_party/skia 3f2d909d7029..53f5db5e9833 (1 commits) (flutter/engine#5683) * flutter/engine@686ee99d8 Roll src/third_party/skia 9eb1c7d80fb3..3f2d909d7029 (1 commits) (flutter/engine#5682) * flutter/engine@936a38dda Roll src/third_party/skia 44bad2e86a01..9eb1c7d80fb3 (1 commits) (flutter/engine#5681) * flutter/engine@6f8788625 Roll src/third_party/skia e72c144af687..44bad2e86a01 (1 commits) (flutter/engine#5680) * flutter/engine@23ae68dfd Roll src/third_party/skia a93486b095ea..e72c144af687 (1 commits) (flutter/engine#5679) * flutter/engine@c6ab9b941 Roll src/third_party/skia 5788bb9af9ad..a93486b095ea (1 commits) (flutter/engine#5678) * flutter/engine@aa4afc14b Roll src/third_party/skia 9b80bd5f16e6..5788bb9af9ad (1 commits) (flutter/engine#5677) * flutter/engine@9f9c06234 Roll src/third_party/skia cdefa23a23cf..9b80bd5f16e6 (1 commits) (flutter/engine#5676) * flutter/engine@4128a799c Roll src/third_party/skia 233c65202e69..cdefa23a23cf (1 commits) (flutter/engine#5675) * flutter/engine@74dc963ab Roll src/third_party/skia 6784ffa78e70..233c65202e69 (1 commits) (flutter/engine#5674) * flutter/engine@5724faf86 ensure that bridge is not destroyed when semantics is still enabled (flutter/engine#5672) * flutter/engine@24af9ca6c [fuchsia] Update gn label for fuchsia.ui.scenic (flutter/engine#5673) * flutter/engine@d085f1df2 Do not make an extra submit callback during SurfaceFrame destruction if the frame was already submitted (flutter/engine#5669) * flutter/engine@b66301055 Roll src/third_party/skia 58a1605d2b9b..6784ffa78e70 (8 commits) (flutter/engine#5671) * flutter/engine@2b890c804 Roll src/third_party/skia 34aa059c1502..58a1605d2b9b (6 commits) (flutter/engine#5667) * flutter/engine@2a88ecf17 Roll src/third_party/skia 94d57c477fe1..34aa059c1502 (8 commits) (flutter/engine#5666) * flutter/engine@51785d244 Remove unused Java imports (flutter/engine#5663) * flutter/engine@b157d4f56 Roll dart sdk to 64641d014b77bd410e9aa10558522ae26e4210ee (flutter/engine#5610) * flutter/engine@d05225ed9 Roll src/third_party/skia d7425b58df89..94d57c477fe1 (1 commits) (flutter/engine#5665) * flutter/engine@32736d52c Roll src/third_party/skia a22d924763ab..d7425b58df89 (4 commits) (flutter/engine#5664) * flutter/engine@0fca44477 Roll src/third_party/skia ef21d7e47963..a22d924763ab (3 commits) (flutter/engine#5662) * flutter/engine@a7d0f29c7 Roll src/third_party/skia 9aa30c6ee0e5..ef21d7e47963 (5 commits) (flutter/engine#5661) * flutter/engine@21c7d6a5d Revert "Add antiAlias and saveCount to clipPath and restore (flutter/engine#5638)" (flutter#5660) * flutter/engine@70dcbb591 Roll src/third_party/skia d818ebf4a317..9aa30c6ee0e5 (11 commits) (flutter/engine#5658) * flutter/engine@ad42324a6 Roll src/third_party/skia a219419c9d76..d818ebf4a317 (2 commits) (flutter/engine#5657) * flutter/engine@f2eb83ae2 Roll src/third_party/skia 00d2e8ebcb13..a219419c9d76 (1 commits) (flutter/engine#5655) * flutter/engine@0ec766946 Roll src/third_party/skia 8451daabb23d..00d2e8ebcb13 (1 commits) (flutter/engine#5654) * flutter/engine@061e899b5 Support all keyboard actions. (flutter/engine#11344) (flutter#5620) * flutter/engine@bc6b2501c Roll src/third_party/skia 34024a7c478c..8451daabb23d (1 commits) (flutter/engine#5653) * flutter/engine@df4dffb10 Roll src/third_party/skia 75e69028956d..34024a7c478c (1 commits) (flutter/engine#5652) * flutter/engine@d8770d440 Roll src/third_party/skia cf863fb9b446..75e69028956d (1 commits) (flutter/engine#5651) * flutter/engine@b88a8b3d5 Roll src/third_party/skia b7b9d02ac020..cf863fb9b446 (1 commits) (flutter/engine#5650) * flutter/engine@2261ccf87 [fuchsia] Update scenic lib path. (flutter/engine#5649) * flutter/engine@4c4ef987a [fuchsia] Rename scenic_lib => scenic (flutter/engine#5648) * flutter/engine@f0c21f327 Roll src/third_party/skia 184d408b646b..b7b9d02ac020 (7 commits) (flutter/engine#5646) * flutter/engine@a2bf80590 Add antiAlias and saveCount to clipPath and restore (flutter/engine#5638) * flutter/engine@9e450d116 Roll src/third_party/skia c91fe3ab1c5d..184d408b646b (10 commits) (flutter/engine#5645) * flutter/engine@e6639963f Roll src/third_party/skia eb8f8106f38c..c91fe3ab1c5d (5 commits) (flutter/engine#5644) * flutter/engine@fecd66f34 Roll src/third_party/skia 723b1f6ef941..eb8f8106f38c (1 commits) (flutter/engine#5643) * flutter/engine@4466d61a9 Remove vmservice_io.main from entry points. (flutter/engine#5625) * flutter/engine@f279dfe30 Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits) (flutter/engine#5642) * flutter/engine@a885bd4f9 Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits) (flutter/engine#5641) * flutter/engine@ad1bd4743 Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits) (flutter/engine#5639)
bkonyi
pushed a commit
that referenced
this pull request
Jul 13, 2018
* Roll dart to 84ca27a. Changes since last roll: ``` 84ca27a Fix File::OpenUri on Windows. 5403f65 Merge existing metadata into new incrementally compiled components. 3cc0a9a Another fix for a race in a test. 4aacaeb [vm/compiler] Fix handling of exception-throwing instructions in DSE 4ff4620 Adjust status lines for safari (take 2) c5c18a0 Introduce percent decoding in File::OpenUri. 550f294 Move some analysis to analyzer-analysis-server-linux and make analyzer-analysis-server-linux a try bot. f5de04f Apply resolution to directive annotations. 6d328b7 Correctly parse dartdoc before abstract class 25969b2 Store resolution for abstract class constructor invocation. 973f73b Handle invalid types from front end. bab152a Fix default in gardening tools 007dcd4 Upgrade package:http to 0.11.3+17. 2519892 Address a race condition in a test. ed0ccc7 Add more error message mappings f0560a8 Add error code ArgumentTypeNotAssignable to improve messaging (issue 33712) 660b8b7 [fuchsia] Update path to timezone service acd8f34 Update safari status 4ab0827 [gn] Remove dart_test_bootfs 1c673b1 Include bounds in type literals 3a1b09d Fix for bug #33660 810cdf8 Add tests for bug #33660 ac05595 Memory file system returns Uint8List from readAsBytes d26dba1 More positions in dart2 constant evaluator eafc52a Add a recovery test 8be1ddb Throw FileSystemException from _FileSystemEntityAdaptor when the file does not exist. 98391f2 [vm] Refactoring: move StreamingScopeBuilder out of kernel_binary_flowgraph 6dfc4ef Remove old dart2analyzer not strong status file entries. 32d208d Revert "Adjust status lines for safari" 5da24bb Adjust status lines for safari c1f6c9d Fix dart2js-hostassert configuration and enable it on the CQ 1717371 Move InferredData to GlobalTypeInferenceResults 403e7c8 Use DataComputer class to implement equivalence based tests 5dbf6da Remove generics where only ir.Node is used da9705b Split compileLoadedLibraries 04168fa Move more methods to ClassHierarchy. a4c47af Fix global-inference bug. 3e33c3d Eliminate analysis warnings in pkg/ code. 72f3abc Fix force-strong flag. e3323ae [vm/inliner] Inline typed data on 32-bit archs. f5a3af4 [VM] A const bool.fromEnvironment() with an explicit defaultValue of `null` should default to `null` 1a08800 Run analyzer --use-fasta-parser on the language2 tests; update status file. aa6dc1e [fasta] Resolve redirecting factories invocations after bodies are built 31cd00b Mark the analysis server integration tests as slow. 65ee951 Force tests to fail pending implementation. d52555c Update the changelog for analyzer changes. d6cf9b4 Deprecate and remove the implementation of an older flag. 609a191 Basic implementation of MOVE_FILE for files 149c5a0 Improve formatting of errors in golden files a600171 Update expectations after parser updates 7570fb8 [fasta] Set parent of annotations in BodyBuilder.finishMetadata. e8ff3d5 Deprecate and ignore the --strong flag on dartanalyzer. a5b8ed1 Have dart2analyzer no longer use the --no-preview-dart-2 flag in test.py. 58e7402 Initial attempt to analyze stack traces a07b2a1 Changed all warnings to errors in the language specification. 5b5e36f Remove use of deprecated methods and constants. 1400cf6 Add named configurations to test matrix. 5d2405f Update the status file for slow tests. 9871ad2 [infra] Move fasta legacy mode SDK tests to their own builder bb69cc1 Add ClassHierarchy to share code between J/KClosedWorld (second attempt) 148013f Re-add tests for MOVE_FILE refactoring. 9873f04 Update service test to not be different in sync async mode dbd97fb Prep for analyzer 0.32.3, front_end 0.1.3, kernel 0.3.3 6e8332b Remove older analyzer bots. eeb5449 More slow test status file updates c339846 [kernel] Move util.dart from bin to lib. 11123b7 Adjust status lines for firefox 620ab34 [vm] Implement reading of parameter annotations from kernel 7d7e39a [build] Move dart2js run for Observatory from python to GN 3c5fe3c Prevent npe when constructor cannot be resolved d50fa68 Update strong status in host-checked mode 6218c0f Mark analyzer tests as slow. f39eaf9 [vm] Refactoring: remove dependency of StreamingScopeBuilder on StreamingFlowGraphBuilder d5ccb53 Remove more uses of isInstanceOf 7007137 Adjustments to dart2js test matrix. 45eee81 Check another case of StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC. 4c789e9 Support the instantiation of abstract constructors d3b4ba3 Revert "Fix #32227 export dynamic from dart:core in analyzer." aa93fa1 Update documentation of --host-checked. afaca9f Use field for class hierarchy map 46bfa72 Have the regular analyzer bots test in dart 2 mode. 90e9fec Add changelog entry for language change on int literals 8c63d57 [vm] Refactoring: move out classes independent of StreamingFlowGraphBuilder aa00933 Update test matrix for dart2js 5352554 Add tests for instance create of an abstract generic class 33f58d5 Add dump-info end to end test 98a2e90 [vm] Combine internal and external allocation into one allocation limit. 2876159 Resolve arguments and type arguments for unresolved invocations. c99268f Replace handleUnrecoverableError with handleRecoverableError 0ccdc3e Reland: [dart:io] Adds Socket.startConnect c9fd951 Add file path to ResolutionApplier error message fb762be Update dart_style to version 1.1.1 in DEPS db7085a Rename UnresolvedTargetInvocation. b803d74 Adjusted errors for FutureOr in class headers c407e83 Delete duplicate key "configurations" in test_matrix.json b303f5a Add flag --named-configuration (-n) to test.py options. 22b9847 [analyzer][cfe] Don't crash on converting errors with Severity.context 4fd0404 Adjusted circularity prevention rule for type variable subtyping 1467909 Call _completeOnAsyncReturn instead of .complete directly b7b24e9 Update dart2js-strong status across several suites 11e0015 Update analysis options files. ed6c096 Remove old entries from pkg/pkg.status. 30807fe [VM interpreter] Fix InterpretCall stub. The stub was marking the thread as executing VM code too early, since the slow path of AllocateArray (called via PushArrayOfArguments) calls into the runtime. With this fix, DeltaBlueClosures can run in fully interpreted mode. 10c13e0 - deprecate strong-mode: options - move those settings to the language: options settings - ignore strong-mode: false in the analysis options file 3a22666 Clearing a LinkedHashMap should not do big allocations adb4b4a Remove another call to handleUnrecoverableError fd26d67 Added getLegacyStats until Chrome fully supports new getStats() API. ``` * Update license hash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll dart to 84ca27a.
Changes since last roll: