This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add tests for errors encoding message channel request and method calls. #56914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error not being copied in this case.
hbatagelo
reviewed
Dec 3, 2024
hbatagelo
approved these changes
Dec 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 4, 2024
flutter/engine@938f816...1e6864c 2024-12-04 34871572+gmackall@users.noreply.github.com [Android] Save back handling state in Activity/Fragment bundle (flutter/engine#56715) 2024-12-03 robert.ancell@canonical.com Split keyevent channel into own class (flutter/engine#56911) 2024-12-03 robert.ancell@canonical.com Add tests for errors encoding message channel request and method calls. (flutter/engine#56914) 2024-12-03 skia-flutter-autoroll@skia.org Roll Skia from 8dc8bdc364f5 to e02d856f86fb (3 revisions) (flutter/engine#56926) 2024-12-03 jonahwilliams@google.com [Impeller] invalidate cached atlas data, take 2. (flutter/engine#56925) 2024-12-03 jason-simmons@users.noreply.github.com Add typeface_proxy dependency to the Skia build script for the Android font manager (flutter/engine#56924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…s. (flutter/engine#56914) Fix error not being copied in this case. Follow up to flutter/engine#56856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error not being copied in this case.
Follow up to #56856