This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType #56744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
`kDefaultBackendType` is intended to make life easier for authors of tests, but in any switch statement where it's used (currently just a single location), we rely on ordering it first and `#ifdef`ing out all backends that aren't available. Instead, we define a static function that returns the default that callers can invoke instead. This avoids relinace on case ordering and fallthrough. In #56722 we split backends out into separate translation units, and remove the `#ifdef`s which means we can't rely on this trick anymore.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 22, 2024
flutter/engine@6f941c9...202506d 2024-11-22 jonahwilliams@google.com [Impeller] cache and reuse openGL framebuffer attachments. (flutter/engine#56746) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 700e685861c8 to e7caf38140ce (25 revisions) (flutter/engine#56756) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from c1106f7e4cde to 141291fd570d (1 revision) (flutter/engine#56748) 2024-11-22 jonahwilliams@google.com [engine] more consistently flush dart event loop, run vsync callback immediately (flutter/engine#56738) 2024-11-22 chris@bracken.jp Extract backend-specific code in ShellTestPlatformView (flutter/engine#56722) 2024-11-22 chris@bracken.jp Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType (flutter/engine#56744) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2614590b4f32 to 700e685861c8 (1 revision) (flutter/engine#56725) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b36e4d731d67 to c1106f7e4cde (12 revisions) (flutter/engine#56742) 2024-11-22 chinmaygarde@google.com [Impeller] libImpeller: A C++ wrapper to the Impeller API. (flutter/engine#56682) 2024-11-21 chinmaygarde@google.com [Impeller] Run simulator tests with Impeller enabled. (flutter/engine#56740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 22, 2024
…159345)" (#159360) <!-- start_original_pr_link --> Reverts: #159345 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: hannah-hyj <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: tree is red on " Linux_build_test flutter_gallery__transition_perf_hybrid" after engine auto roll <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: engine-flutter-autoroll <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {fluttergithubbot} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: flutter/engine@6f941c9...202506d 2024-11-22 jonahwilliams@google.com [Impeller] cache and reuse openGL framebuffer attachments. (flutter/engine#56746) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 700e685861c8 to e7caf38140ce (25 revisions) (flutter/engine#56756) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from c1106f7e4cde to 141291fd570d (1 revision) (flutter/engine#56748) 2024-11-22 jonahwilliams@google.com [engine] more consistently flush dart event loop, run vsync callback immediately (flutter/engine#56738) 2024-11-22 chris@bracken.jp Extract backend-specific code in ShellTestPlatformView (flutter/engine#56722) 2024-11-22 chris@bracken.jp Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType (flutter/engine#56744) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2614590b4f32 to 700e685861c8 (1 revision) (flutter/engine#56725) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b36e4d731d67 to c1106f7e4cde (12 revisions) (flutter/engine#56742) 2024-11-22 chinmaygarde@google.com [Impeller] libImpeller: A C++ wrapper to the Impeller API. (flutter/engine#56682) 2024-11-21 chinmaygarde@google.com [Impeller] Run simulator tests with Impeller enabled. (flutter/engine#56740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2024
flutter/engine@6f941c9...f776c3a 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from e7caf38140ce to c3d9596a93f8 (2 revisions) (flutter/engine#56765) 2024-11-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] more consistently flush dart event loop, run vsync callback immediately (#56738)" (flutter/engine#56767) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 8b65a7a628e2 to eb01a0430f72 (2 revisions) (flutter/engine#56764) 2024-11-22 jonahwilliams@google.com [Impeller] delete Impeller sim opt out. (flutter/engine#56706) 2024-11-22 jason-simmons@users.noreply.github.com [Impeller] Ensure that SnapshotControllerImpeller has a rendering context before creating the snapshot (flutter/engine#56743) 2024-11-22 flar@google.com [DisplayList] migrate DlColorSource objects to Impeller geometry (flutter/engine#56735) 2024-11-22 chinmaygarde@google.com [Impeller] libImpeller: Tinker on the README. (flutter/engine#56761) 2024-11-22 jonahwilliams@google.com [Impeller] dont create temp vec for discard. (flutter/engine#56759) 2024-11-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zhFzwYCH-N_wasTnM... to D5CBHuB2c-v3Zai-c... (flutter/engine#56757) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 141291fd570d to 8b65a7a628e2 (1 revision) (flutter/engine#56755) 2024-11-22 jonahwilliams@google.com [Impeller] cache and reuse openGL framebuffer attachments. (flutter/engine#56746) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 700e685861c8 to e7caf38140ce (25 revisions) (flutter/engine#56756) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from c1106f7e4cde to 141291fd570d (1 revision) (flutter/engine#56748) 2024-11-22 jonahwilliams@google.com [engine] more consistently flush dart event loop, run vsync callback immediately (flutter/engine#56738) 2024-11-22 chris@bracken.jp Extract backend-specific code in ShellTestPlatformView (flutter/engine#56722) 2024-11-22 chris@bracken.jp Eliminate ShellTestPlatformView::BackendType::kDefaultBackendType (flutter/engine#56744) 2024-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2614590b4f32 to 700e685861c8 (1 revision) (flutter/engine#56725) 2024-11-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b36e4d731d67 to c1106f7e4cde (12 revisions) (flutter/engine#56742) 2024-11-22 chinmaygarde@google.com [Impeller] libImpeller: A C++ wrapper to the Impeller API. (flutter/engine#56682) 2024-11-21 chinmaygarde@google.com [Impeller] Run simulator tests with Impeller enabled. (flutter/engine#56740) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from zhFzwYCH-N_w to D5CBHuB2c-v3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…utter/engine#56744) `kDefaultBackendType` is intended to make life easier for authors of tests, but in any switch statement where it's used (currently just a single location), we rely on ordering it first and `#ifdef`ing out all backends that aren't available. Instead, we define a static function that returns the default that callers can invoke instead. This avoids relinace on case ordering and fallthrough. In flutter/engine#56722 we split backends out into separate translation units, and ideally should remove the `#ifdef`s, which means we can't rely on this trick anymore. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kDefaultBackendTypeis intended to make life easier for authors of tests, but in any switch statement where it's used (currently just a single location), we rely on ordering it first and#ifdefing out all backends that aren't available.Instead, we define a static function that returns the default that callers can invoke instead. This avoids reliance on case ordering and fallthrough.
In #56722 we split backends out into separate translation units, and should remove the
#ifdefs, which means we can't rely on this trick anymore.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.