Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jul 2, 2018

This reverts commit a2bf805.

Reason for revert: need to fix several things including the framework test in order to unblock the engine roll.

@liyuqian
Copy link
Contributor Author

liyuqian commented Jul 2, 2018

@matthew-carroll : no conflicts are detected when I tried to run git revert ... in command line. I've no idea why github failed to revert automatically.

@liyuqian liyuqian merged commit 21c7d6a into flutter:master Jul 2, 2018
@matthew-carroll
Copy link
Contributor

If the changes look like the correct reversion to you, then LGTM.

@Hixie
Copy link
Contributor

Hixie commented Jul 3, 2018

GitHub is pretty conservative about what it thinks it can revert automatically.

liyuqian added a commit to liyuqian/engine that referenced this pull request Jul 3, 2018
bkonyi pushed a commit that referenced this pull request Jul 13, 2018
…5660)

This reverts commit a2bf805.

Reason for revert: need to fix several things including the framework test in order to unblock the engine roll.

TBR: @matthew-carroll
@liyuqian liyuqian deleted the revert branch September 12, 2018 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants