Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Nov 7, 2024

This matches FlScrollingManager and FlKeyboardManager.

Add tests for this behaviour that was previously missing.

…table for Flutter.

This matches FlScrollingManager and FlKeyboardManager.

Add tests for this behaviuour that was previously missing.
@robert-ancell
Copy link
Contributor Author

@mattkae @hbatagelo trying to add you as reviewers too, but it's not allowing me. Perhaps you need some more memberships from https://github.com/flutter/flutter/blob/master/docs/contributing/Contributor-access.md?

@hbatagelo
Copy link
Contributor

@mattkae @hbatagelo trying to add you as reviewers too, but it's not allowing me. Perhaps you need some more memberships from https://github.com/flutter/flutter/blob/master/docs/contributing/Contributor-access.md?

I think we'll first need the "contributor access" status as mentioned in the document. Could you be our sponsor and ask on #server-support to make us contributors? I'm not sure if this alone is sufficient, but it appears to be a prerequisite.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

lgtm with a couple nits.

@robert-ancell robert-ancell merged commit b0a4ca9 into flutter:main Nov 12, 2024
@robert-ancell robert-ancell deleted the linux-pointer-manager branch November 12, 2024 01:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 12, 2024
flutter/engine@a672f97...b0a4ca9

2024-11-12 robert.ancell@canonical.com Add FlPointerManager to process pointer events from GTK in a form suitable for Flutter. (flutter/engine#56443)
2024-11-12 skia-flutter-autoroll@skia.org Roll Skia from 11046fd10394 to 75230dbc93e6 (1 revision) (flutter/engine#56517)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…table for Flutter. (flutter/engine#56443)

This matches FlScrollingManager and FlKeyboardManager.

Add tests for this behaviour that was previously missing.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants