This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) #56401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11 2024-10-02 dayeung@chromium.org Updated TZ to 2024b 2024-09-05 andreaorru@chromium.org Remove icudtl.dat.hash If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter-engine Please CC fuchsia-ui-discuss@google.com,jsimmons@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
981f089 to
6faaabc
Compare
fluttergithubbot
approved these changes
Nov 6, 2024
Contributor
|
auto label is removed for flutter/engine/56401, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/engine/56401, due to - The status or check suite Mac clangd has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
|
auto label is removed for flutter/engine/56401, due to - The status or check suite Mac clangd has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
Author
|
Commit queue failed; closing this roll. |
Contributor
|
Need to manually adjust the license file. |
Contributor
|
No permission to access this branch, I will create a new PR instead. |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Redo #56401 with a manual license change to remove the chromeos/icudtl.dat.hash. The file was removed by https://crrev.com/83a7bd47a345137ac6081c71c2a7158f5403cd30. Original change description: https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11 2024-10-02 [dayeung@chromium.org](mailto:dayeung@chromium.org) Updated TZ to 2024b 2024-09-05 [andreaorru@chromium.org](mailto:andreaorru@chromium.org) Remove icudtl.dat.hash If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter-engine Please CC [fuchsia-ui-discuss@google.com](mailto:fuchsia-ui-discuss@google.com),[jsimmons@google.com](mailto:jsimmons@google.com) on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11
2024-10-02 dayeung@chromium.org Updated TZ to 2024b
2024-09-05 andreaorru@chromium.org Remove icudtl.dat.hash
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC fuchsia-ui-discuss@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md