This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] check if memory type is host coherent, avoid flush. #56350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
reviewed
Nov 4, 2024
added 4 commits
November 4, 2024 09:52
jtmcdole
approved these changes
Nov 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
Member
|
Is this flake on linux unopt related? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8732165624116282801/+/u/test:_Host_Tests_for_host_debug_unopt_impeller_tests/stdout |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2024
…158148) flutter/engine@75accee...6271a92 2024-11-04 matanlurey@users.noreply.github.com Add and document `et cleanup`. (flutter/engine#56327) 2024-11-04 jonahwilliams@google.com [Impeller] check if memory type is host coherent, avoid flush. (flutter/engine#56350) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
Author
|
Probably, let me fix the test.... |
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…er/engine#56350) Fixes flutter#137454 Host coherent memory does not need to be flushed. Almost all mobile devices will have host coherent memory for us to write to, but we still need check because of swiftshader and/or desktop at some point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#137454
Host coherent memory does not need to be flushed. Almost all mobile devices will have host coherent memory for us to write to, but we still need check because of swiftshader and/or desktop at some point.