This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Write run_tests console logs to stdout instead of stderr #56312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Nov 1, 2024
Member
zanderso
left a comment
There was a problem hiding this comment.
Could you add some description about why this is needed to the PR description?
| LOG_FILE = os.path.join(OUT_DIR, 'run_tests.log') | ||
| logger = logging.getLogger(__name__) | ||
| console_logger_handler = logging.StreamHandler() | ||
| console_logger_handler = logging.StreamHandler(sys_stdout) |
Member
There was a problem hiding this comment.
Consider adding a comment here explaining why this is needed.
zanderso
approved these changes
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 2, 2024
flutter/engine@7dfdcac...38b6165 2024-11-01 jonahwilliams@google.com [Impeller] fix downsample with decal tile mode. (flutter/engine#56316) 2024-11-01 skia-flutter-autoroll@skia.org Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320) 2024-11-01 jacksongardner@google.com Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315) 2024-11-01 jason-simmons@users.noreply.github.com Write run_tests console logs to stdout instead of stderr (flutter/engine#56312) 2024-11-01 jonahwilliams@google.com [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ine#56312) Users of this script typically expect that the normal output of the tests will be written to stdout. However, the logging.StreamHandler writes to stderr by default unless another stream is specified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of this script typically expect that the normal output of the tests will be written to stdout. However, the logging.StreamHandler writes to stderr by default unless another stream is specified.